Bug 209139 - [MAINTAINER] sysutils/fcron: upgrade to 3.2.0 and change maintainer email
Summary: [MAINTAINER] sysutils/fcron: upgrade to 3.2.0 and change maintainer email
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-28 23:22 UTC by Bob Eager
Modified: 2016-05-08 09:35 UTC (History)
3 users (show)

See Also:
rde: maintainer-feedback+


Attachments
Patches for Makefile, distinfo and files/patch* (12.23 KB, patch)
2016-04-28 23:22 UTC, Bob Eager
bob: maintainer-approval+
Details | Diff
Revised patches for Makefile, distinfo and files/* (13.04 KB, patch)
2016-05-07 20:26 UTC, Bob Eager
no flags Details | Diff
Second revision of port diff! (13.65 KB, patch)
2016-05-07 21:37 UTC, Bob Eager
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Eager 2016-04-28 23:22:09 UTC
Created attachment 169795 [details]
Patches for Makefile, distinfo and files/patch*

IMPORTANT: the Makefile is patched to change maintainer from rde@tavi.co.uk to bob@eager.cx (all of the maintainer's other ports are with bob@eager.cx, and this makes sense). It's the same physical maintainer (me).

- upgrade to 3.2.0
- tidied Makefile
- removed broken repository (still two left)
- tidied rc file (passes rclint)
Comment 1 rde 2016-04-28 23:29:33 UTC
I approve this update. I also approve change of maintainer email address from rde@tavi.co.uk to bob@eager.cx (it's still me, I am consolidating ports under one email address).
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-06 17:23:52 UTC
testbuilds fine, except on current, where it fails with:

fcrondyn.c:691:5: error: use of undeclared identifier 'rl_readline_name'
    rl_readline_name = "fcrondyn";
    ^
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-06 17:32:26 UTC
full poudriere build log from current:

http://people.freebsd.org/~pi/logs/sysutils__fcron-cur-1462555207.txt
Comment 4 Bob Eager 2016-05-07 20:26:26 UTC
Created attachment 170102 [details]
Revised patches for Makefile, distinfo and files/*

New patches for Makefile, distinfo and files/patch*; new files in files/
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-07 20:30:14 UTC
(In reply to bob from comment #4)

Now it fails at

fcrondyn.c:695:5: error: use of undeclared identifier
      'rl_attempted_completion_function'
    rl_attempted_completion_function = rl_cmpl_fcrondyn;
    ^
Comment 6 Bob Eager 2016-05-07 21:36:08 UTC
My apologies. I failed to copy one patch from the test VM. The port's own makefile does not regenerate 'configure' using autoconf, so it's necessary to patch that too.

Revised patches (again) follow.
Comment 7 Bob Eager 2016-05-07 21:37:22 UTC
Created attachment 170104 [details]
Second revision of port diff!

Second revision, including files/patch-configure
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-08 09:27:49 UTC
Testbuilds and build on populated host are now fine.
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-05-08 09:34:29 UTC
A commit references this bug:

Author: pi
Date: Sun May  8 09:33:27 UTC 2016
New revision: 414794
URL: https://svnweb.freebsd.org/changeset/ports/414794

Log:
  sysutils/fcron: 3.0.6 -> 3.2.0

  Changes:
    http://fcron.free.fr/doc/en/changes.html
  - updated maintainer mail

  PR:		209139
  Submitted by:	bob@eager.cx (maintainer)

Changes:
  head/sysutils/fcron/Makefile
  head/sysutils/fcron/distinfo
  head/sysutils/fcron/files/fcron.in
  head/sysutils/fcron/files/patch-configure
  head/sysutils/fcron/files/patch-doc_en_man_fcron.8
  head/sysutils/fcron/files/patch-doc_en_man_fcron.conf.5
  head/sysutils/fcron/files/patch-doc_en_man_fcrontab.1
  head/sysutils/fcron/files/patch-doc_fr_man_fcron.8
  head/sysutils/fcron/files/patch-fcrondyn.c
  head/sysutils/fcron/files/patch-fileconf.c
  head/sysutils/fcron/files/patch-files_fcron.pam
  head/sysutils/fcron/files/patch-m4_ax__lib__readline.m4
  head/sysutils/fcron/files/patch-save.c
  head/sysutils/fcron/files/patch-subs.c
  head/sysutils/fcron/pkg-plist
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-08 09:35:37 UTC
Committed, thanks!