Bug 209201 - [MAINTAINER] devel/libbson: Update to 1.3.5
Summary: [MAINTAINER] devel/libbson: Update to 1.3.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jason Unovitch
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2016-05-02 13:32 UTC by Krzysztof
Modified: 2016-05-03 01:54 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+


Attachments
libbson update to 1.3.5 (927 bytes, patch)
2016-05-02 13:32 UTC, Krzysztof
ports: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2016-05-02 13:32:34 UTC
Created attachment 169881 [details]
libbson update to 1.3.5

There is new version of devel/libbson port. It was published the same time as devel/mongo-c-driver port. So this port should be updated also.

I've made a patch and tested it with poudriere. You can check logfile at https://rtm.bsdserwis.com/poudriere/data/a1amd64-testing/2016-05-02_15h21m10s/logs/libbson-1.3.5.log
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2016-05-03 01:11:51 UTC
It looks like devel/mongo-c-driver was updated to 1.3.5 in r414122/bug #208930. Is that a hard dependency that means the PR should be marked "depends on"?  I'm not marking that now.  QA'ing now.
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2016-05-03 01:20:04 UTC
Very strange.  This failed to fetch for me:
=> Attempting to fetch https://codeload.github.com/mongodb/libbson/tar.gz/1.3.5?dummy=/mongodb-libbson-1.3.5_GH0.tar.gz
fetch: https://codeload.github.com/mongodb/libbson/tar.gz/1.3.5?dummy=/mongodb-libbson-1.3.5_GH0.tar.gz: size unknown
fetch: https://codeload.github.com/mongodb/libbson/tar.gz/1.3.5?dummy=/mongodb-libbson-1.3.5_GH0.tar.gz: size of remote file is not known
mongodb-libbson-1.3.5_GH0.tar.gz                        -1  B    0  Bps
=> Fetched file size mismatch (expected 4547720, actual 4040751)

You patch used:
SHA256 (mongodb-libbson-1.3.5_GH0.tar.gz) = d380cfc30bbb598e64bc5e4b0851f9e8343071292a9e0a101f49ec06211a1b23
SIZE (mongodb-libbson-1.3.5_GH0.tar.gz) = 4547720

A `make makesum` run in from one geographic location returned:
SHA256 (mongodb-libbson-1.3.5_GH0.tar.gz) = 351ac37540a2b406563bfc59ecaec4059c61b0f9d7cde7236c0a0e241bde3564
SIZE (mongodb-libbson-1.3.5_GH0.tar.gz) = 4040751

A manual fetch of https://github.com/mongodb/libbson/releases/tag/1.3.5 from another location 600 miles away returned the same SHA256 hash:
jason@Silverstone:/tmp % fetch 'https://github.com/mongodb/libbson/archive/1.3.5.tar.gz'
1.3.5.tar.gz                                  100% of 3946 kB  940 kBps 00m04s
jason@Silverstone:/tmp % sha256 1.3.5.tar.gz 
SHA256 (1.3.5.tar.gz) = 351ac37540a2b406563bfc59ecaec4059c61b0f9d7cde7236c0a0e241bde3564

Pending results with new distinfo.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-05-03 01:52:27 UTC
A commit references this bug:

Author: junovitch
Date: Tue May  3 01:51:35 UTC 2016
New revision: 414506
URL: https://svnweb.freebsd.org/changeset/ports/414506

Log:
  devel/libbson: update 1.3.4 -> 1.3.5

  PR:		209201
  Submitted by:   Krzysztof Stryjek <ports@bsdserwis.com> (maintainer)

Changes:
  head/devel/libbson/Makefile
  head/devel/libbson/distinfo
Comment 4 Jason Unovitch freebsd_committer freebsd_triage 2016-05-03 01:54:52 UTC
Krzysztof,
I'm not sure what happened with the distinfo but I had the two different sources check out to the same SHA256 so went with that.  QA noted no issues.  If you note anything out of the ordinary or have any insight on the munged distinfo I would appreciate if you make a note of it.

Thanks for your continual efforts!