Created attachment 169937 [details] patch to unbreak scilab build with hdf5 1.10 and other fixes When hdf5 was upgraded to version 1.10, it broke the scilab build: src/c/h5_readDataFromFile.c:719:64: error: too few arguments to function call, expected 4, have 3 obj = H5Rdereference(_iDatasetId, H5R_OBJECT, &pData[i]); ~~~~~~~~~~~~~~ ^ /usr/local/include/H5Rpublic.h:63:8: note: 'H5Rdereference2' declared here The build fix to math/matio in #209242 is necessary to get this far because matio is a non-optional dependency. The attached patch fixes the scilab build. Also, fix the build when the GUI option is disabled. While here, quiet a bunch of portlint warnings. Since this port installs both icons and shared libraries, add USE_LDCONFIG= yes and INSTALLS_ICONS= yes to Makefile.
(In reply to Don Lewis from comment #0) > Created attachment 169937 [details] > patch to unbreak scilab build with hdf5 1.10 and other fixes > > When hdf5 was upgraded to version 1.10, it broke the scilab build: > > src/c/h5_readDataFromFile.c:719:64: error: too few arguments to function > call, expected 4, have 3 > obj = H5Rdereference(_iDatasetId, H5R_OBJECT, &pData[i]); > ~~~~~~~~~~~~~~ ^ > /usr/local/include/H5Rpublic.h:63:8: note: 'H5Rdereference2' declared here > > The build fix to math/matio in #209242 is necessary to get this far because > matio is a non-optional dependency. > > The attached patch fixes the scilab build. > > Also, fix the build when the GUI option is disabled. Approved. > While here, quiet a bunch of portlint warnings. Since this port installs > both icons and shared libraries, add > USE_LDCONFIG= yes Porlint is not perfect and this USE_LDCONFIG is superfluous here. Scilab install s its libraries into a privite directory, they are not used by other ports. > and > INSTALLS_ICONS= yes Ok.
A commit references this bug: Author: truckman Date: Fri May 6 21:45:20 UTC 2016 New revision: 414732 URL: https://svnweb.freebsd.org/changeset/ports/414732 Log: Fix build with science/hdf5 version 1.10 by specifying that we want to use the version 1.8 API. Fix the build when the GUI option is disabled. Since this port installs icons, add INSTALLS_ICONS=yes to Makefile. PR: 209244 Approved by: makc (maintainer) Changes: head/math/scilab/Makefile head/math/scilab/files/patch-modules_hdf5_includes_HDF5Objects.h head/math/scilab/files/patch-modules_hdf5_src_c_h5__readDataFromFile.c head/math/scilab/files/patch-modules_hdf5_src_c_h5__readDataFromFile__v1.c
This problem was fixed by the patch committed in r414720 which tells the port to specifically request the version 1.8 API. It doesn't require any changes to hdf5.