Created attachment 170096 [details] rar.patch archivers/rar installs a statically linked version of the rar executable. As a result, the misc/compat9x dependency is not actually needed by rar itself. I've been told it is needed by self-extractors made with rar (see bug #199704), but otherwise, it is not needed at all. If it would be better to make this an OPTION, like the aforementioned bug suggests, I could provide a replacement patch for that.
You should make it an OPTION. Breaking the port for "some" is usually the wrong choice. Having it as an OPTION makes it work for everybody. I'd see nothing wrong with making it off by default.
Created attachment 170518 [details] rar.patch I've updated the patch so SFX support is now an option. Because I cannot make an option be added after bsd.port.pre.mk is included (which is where OPSYS and OSVERSION are defined), I settled on a suggestion from Avengence to unconditionally add the option, disabled by default. I made the description note that the option is only needed for FreeBSD 10 and up.
Given that 9.x is reaching EOL in 7 months, what about saying "unnecessary on FreeBSD 9" or something like that instead?
That could work instead, I'm fine with either way, I just personally don't want misc/compat9x installed because of this port. :P
Sorry Naram, I didn't realize that archivers/rar was maintained by gabor. He's the maintainer so it's his call. I don't know why this didn't get auto-assigned to Gabor, but I'm reassigning it to him now.
Committed, thanks.
A commit references this bug: Author: gabor Date: Thu Sep 8 19:57:01 UTC 2016 New revision: 421575 URL: https://svnweb.freebsd.org/changeset/ports/421575 Log: - Update to 5.4.0 - Add an option for SFX archive support [1] PR: 209365 [1] Submitted by: Naram Oashat <cyberbotx@cyberbotx.com> Changes: head/archivers/rar/Makefile head/archivers/rar/distinfo