Bug 209481 - www/node: add armv6 support
Summary: www/node: add armv6 support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 12:13 UTC by Mikael Urankar
Modified: 2016-05-19 05:32 UTC (History)
2 users (show)

See Also:
bhughes: maintainer-feedback+

Attachments
armv6 patch (8.95 KB, patch)
2016-05-13 12:13 UTC, Mikael Urankar 		no flags Details | Diff
armv6 patch (7.70 KB, patch)
2016-05-17 08:07 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2016-05-13 12:13:19 UTC 
Created attachment 170243 [details]
armv6 patch

Hi,
This patch allows www/node to build on armv6
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2016-05-13 12:14:45 UTC 
build log:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/node-6.1.0.log
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-15 20:15:02 UTC 
testbuild@work
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-16 05:35:10 UTC 
Testbuild on 11.0-CURRENT r299220 arm.armv6 was sucessful.
Comment 4 Bradley T. Hughes freebsd_committer freebsd_triage 2016-05-16 10:03:03 UTC 
The openssl patches surprise me. Why are they needed? I ask because the security/openssl port is the same version as the bundled version in node.js, but I don't see these kinds of armv6 patches there.
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2016-05-17 08:07:21 UTC 
Created attachment 170390 [details]
armv6 patch

(In reply to Bradley T. Hughes from comment #4)
The openssl patch is only needed if with build openssl with ASM on. It's not the case since openssl is built with --openssl-no-asm...
I've attached a new patch without the openssl patch, it still compiles fine.
Thanks for pointing this out.
Comment 6 Bradley T. Hughes freebsd_committer freebsd_triage 2016-05-18 06:28:19 UTC 
The new patch looks almost identical to the original, with several patches to deps/openssl/* files. Is that right?
Comment 7 Mikael Urankar freebsd_committer freebsd_triage 2016-05-18 07:54:26 UTC 
I removed the openssl patch, the only patches left are for the Makefile and deps/v8/src/*:
+++ Makefile
+++ files/patch-deps_v8_src_arm_cpu-arm.cc
+++ files/patch-deps_v8_src_base_atomicops_internals_arm_gcc.h
+++ files/patch-deps_v8_src_base_platform_platform-freebsd.cc
+++ files/patch-deps_v8_src_profiler_sampler.cc
Comment 8 Bradley T. Hughes freebsd_committer freebsd_triage 2016-05-18 08:50:45 UTC 
Yes, indeed, sorry about that. This looks good to me.
Comment 9 Bradley T. Hughes freebsd_committer freebsd_triage 2016-05-18 08:51:57 UTC 
Comment on attachment 170390 [details]
armv6 patch

LGTM
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-18 19:20:02 UTC 
testbuild@work
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-19 05:21:55 UTC 
testbuild on armv6 is ok
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-05-19 05:25:26 UTC 
A commit references this bug:

Author: pi
Date: Thu May 19 05:24:48 UTC 2016
New revision: 415490
URL: https://svnweb.freebsd.org/changeset/ports/415490

Log:
  www/node: add armv6 support

  PR:		209481
  Submitted by:	mikael.urankar@gmail.com
  Approved by:	bradleythughes@fastmail.fm (maintainer)

Changes:
  head/www/node/Makefile
  head/www/node/files/patch-deps_v8_src_arm_cpu-arm.cc
  head/www/node/files/patch-deps_v8_src_base_atomicops_internals_arm_gcc.h
  head/www/node/files/patch-deps_v8_src_base_platform_platform-freebsd.cc
  head/www/node/files/patch-deps_v8_src_profiler_sampler.cc
Comment 13 Bradley T. Hughes freebsd_committer freebsd_triage 2016-05-19 05:26:37 UTC 
Thanks! :)
Comment 14 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-19 05:32:04 UTC 
Committed, thanks!