Bug 209852 - sysutils/zrep: Update to 1.5.5 and switch to github
Summary: sysutils/zrep: Update to 1.5.5 and switch to github
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jimmy Olgeni
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-05-30 08:30 UTC by Jimmy Olgeni
Modified: 2016-07-19 14:55 UTC (History)
3 users (show)

See Also:
olevole: maintainer-feedback+
olevole: maintainer-feedback+

Attachments
Update patch (7.91 KB, patch)
2016-05-30 08:30 UTC, Jimmy Olgeni 		no flags Details | Diff
Update patch (with LOCALBASE) (7.91 KB, patch)
2016-05-30 14:11 UTC, Jimmy Olgeni 		olgeni: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy Olgeni freebsd_committer freebsd_triage 2016-05-30 08:30:26 UTC 
Created attachment 170818 [details]
Update patch

Update sysutils/zrep to 1.5.5.

- Switch to building from github source
- Split the original patch into multiple files (one for each source)
- Force rebuild of the zrep script with patches

The current port downloads the zrep script from its home page; because the script name has no version distinfo will be invalid when the script is updated.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-05-30 14:07:08 UTC 
> @${REINPLACE_CMD} -e 's|#!/bin/ksh -p|#!${PREFIX}/bin/ksh93 -p|' ${WRKSRC}/zrep_top

You should use LOCALBASE here, not PREFIX.
Comment 2 Jimmy Olgeni freebsd_committer freebsd_triage 2016-05-30 14:10:04 UTC 
(In reply to Dmitry Marakasov from comment #1)

Good catch - let me fix it.
Comment 3 Jimmy Olgeni freebsd_committer freebsd_triage 2016-05-30 14:11:26 UTC 
Created attachment 170828 [details]
Update patch (with LOCALBASE)
Comment 4 Oleg Ginzburg 2016-06-08 15:34:48 UTC 
Sorry for delay.

I've checked this patch and it looks good, I approve it.
Comment 5 Cassiano Peixoto 2016-06-17 19:20:58 UTC 
Are you guys using zrep to replicate large data? I've been using it and after some days (or until weeks) the source machine just stuck ZFS process and i have to reboot it.

I'm replicating every 5 minutes to another server. I tried with different servers and data and same issue happens. I'm not sure if there is something else either with zrep or FreeBSD zfs.

Any tip would be helpful.

Thanks
Comment 6 Jimmy Olgeni freebsd_committer freebsd_triage 2016-06-27 09:08:17 UTC 
(In reply to olevole from comment #4)

Do you mind if I jump to 1.6.1 while I'm there?
Comment 7 Terry Kennedy 2016-06-27 09:13:34 UTC 
(In reply to Jimmy Olgeni from comment #6)

Please see pr210615 for a patch to 1.6.1.
Comment 8 Terry Kennedy 2016-06-27 09:13:55 UTC 
(In reply to Cassiano Peixoto from comment #5)

I am using a newer version of zrep (see pr210615), replicating some 20TB of data on FreeBSD 10.3-amd64. I would think that you are seeing a ZFS issue, not a zrep issue, since zrep uses zfs send/recv "under the hood".

Feel free to email me (I'm on the CC list for this bug) if you'd like to discuss the hang you are seeing, rather than continuing here. We can always return here if it turns out to be a zrep problem.
Comment 9 Jimmy Olgeni freebsd_committer freebsd_triage 2016-06-27 09:17:29 UTC 
(In reply to Terry Kennedy from comment #7)

Nice! Switching to 210615.
Comment 10 Jimmy Olgeni freebsd_committer freebsd_triage 2016-06-27 09:18:18 UTC 
Superseded by 210615.
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-07-19 14:55:31 UTC 
A commit references this bug:

Author: olgeni
Date: Tue Jul 19 14:54:35 UTC 2016
New revision: 418801
URL: https://svnweb.freebsd.org/changeset/ports/418801

Log:
  Update sysutils/zrep to version 1.6.1.

  PR:		209852, 210615
  Submitted by:	Terry Kennedy
  Approved by:	maintainer (209852)

Changes:
  head/sysutils/zrep/Makefile
  head/sysutils/zrep/distinfo