Bug 209959 - audio/faac: Add license
Summary: audio/faac: Add license
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: needs-patch, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-06-02 07:54 UTC by takefu
Modified: 2016-06-20 19:10 UTC (History)
1 user (show)

See Also:
riggs: maintainer-feedback+

Attachments
faac-1.28_4.patch (2.62 KB, patch)
2016-06-02 07:54 UTC, takefu 		no flags Details | Diff
Updated patch (1.80 KB, patch)
2016-06-18 11:12 UTC, Thomas Zander 		riggs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2016-06-02 07:54:00 UTC 
Created attachment 170937 [details]
faac-1.28_4.patch
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2016-06-02 08:01:48 UTC 
This needs a bit of cleanup before committing.
Comment 2 VK freebsd_triage 2016-06-04 10:40:03 UTC 
Takefu@, thanks for the patch. Mathieu, thanks for the feedback. I am assuming you mean to request the reporter submit a new, cleaned up patch, so I'm setting needs-patch. Please correct me if I'm wrong.
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2016-06-18 11:12:39 UTC 
Created attachment 171543 [details]
Updated patch

After trying to get my head around the legalese in all those files (and turning to debian package sources for comparison), I propose the attached revision of the patch. Changes:
- There is no indication for restricted distribution of src distfiles or pkgs (debian folks concur; they distribute packages as well)
- There is no mentioning of the 'sell for profit' clause anywhere in the source tarball -> remove from LEGAL
- The ISO/IEC license parts are part of the README document, not COPYING (latter contains just the GPL parts)
- Keep the noeol fix to the psych.h file
- in faac, patch only Makefile / keep the diff as small as possible for now, address only the licensing topic
- Package metadata and content changes due to LICENSE* tags -> Bump PORTREVISION

@takefu, mat: Could you quickly double-check whether I missed something?
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-06-20 18:59:20 UTC 
A commit references this bug:

Author: riggs
Date: Mon Jun 20 18:58:36 UTC 2016
New revision: 417172
URL: https://svnweb.freebsd.org/changeset/ports/417172

Log:
  Update LICENSE* in audio/faac; remove from LEGAL

  Detailed log:
  - Remove audio/faac from LEGAL. There is no evidence that faac
    may not be redistributed on sold media like FreeBSD CDs/DVDs.
    Other well-established open source organisations arrive at the
    same conclusion, e.g. Debian:
    http://metadata.ftp-master.debian.org/changelogs//non-free/f/faac/faac_1.28-6_copyright
    and, by extension, Ubuntu:
    https://launchpad.net/ubuntu/trusty/+source/faac/+copyright
    Arch Linux ships redistributable packages as well:
    https://www.archlinux.org/packages/?sort=&repo=Extra&q=faac
  - Add LICENSE* tags in audio/faac
  - Bump PORTREVISION in audio/faac (package metadata changes)
  - Pet portlint

  PR:		209959
  Submitted by:	takefu@airport.fm
  Reviewed by:	riggs

Changes:
  head/LEGAL
  head/audio/faac/Makefile