Bug 210033 - games/adgali: UNBREAK and make fetchable
Summary: games/adgali: UNBREAK and make fetchable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-06-04 19:26 UTC by lightside
Modified: 2016-06-09 15:30 UTC (History)
2 users (show)

See Also:


Attachments
Proposed patch (since 416324 revision) (653 bytes, patch)
2016-06-04 19:26 UTC, lightside
vlad-fbsd: maintainer-approval-
Details | Diff
Proposed patch (since 416324 revision) (4.35 KB, patch)
2016-06-07 13:55 UTC, lightside
vlad-fbsd: maintainer-approval+
Details | Diff
The poudriere testport log (FreeBSD 10.2 amd64) (37.16 KB, application/x-bzip2)
2016-06-07 13:56 UTC, lightside
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2016-06-04 19:26:50 UTC
Created attachment 171021 [details]
Proposed patch (since 416324 revision)

Patch to add a mirror for distfile of games/adgali port.
Comment 1 lightside 2016-06-04 19:32:31 UTC
% curl -sLI http://www.sourcefiles.org/Programming/Libraries/Games/adgali-0.2.4.tar.bz2
HTTP/1.1 200 OK
Date: Sat, 04 Jun 2016 13:35:05 GMT
Server: Apache/2.2.3 (Fedora)
Last-Modified: Sun, 18 Mar 2007 02:04:05 GMT
ETag: "288551-ad702-e323ef40"
Accept-Ranges: bytes
Content-Length: 710402
Connection: close
Content-Type: application/x-bzip2
Comment 2 VK freebsd_triage 2016-06-07 12:29:18 UTC
Cleaning up summary in favor of keywords.
Comment 3 VK freebsd_triage 2016-06-07 12:29:51 UTC
Comment on attachment 171021 [details]
Proposed patch (since 416324 revision)

The port has no maintainer, implicit approval.
Comment 4 VK freebsd_triage 2016-06-07 12:37:52 UTC
lightside, thanks for the patch. Please confirm this builds fine, as that confirmation both covers building and implicitly unbreaking, where curl test only confirms the distfile is there.

Also, the original master site doesn't work for me. Did you mean to replace with, instead of add sourcefiles.org?
Comment 5 VK freebsd_triage 2016-06-07 12:38:46 UTC
Comment on attachment 171021 [details]
Proposed patch (since 416324 revision)

Orig master site still doesn't work, reverting implicit approval.
Comment 6 lightside 2016-06-07 13:55:49 UTC
Created attachment 171143 [details]
Proposed patch (since 416324 revision)

(In reply to comment #4)
> Please confirm this builds fine, as that confirmation both covers building
> and implicitly unbreaking, where curl test only confirms the distfile
> is there.
Yes, the port builds fine. I tested in on FreeBSD 10.2 amd64 before PR submit.
I didn't add the poudriere testport log, because this was a distfile only fix (without PORTREVISION change).
The other builds, when distfile was available, are here (for quarterly):
http://portsmon.freebsd.org/portoverview.py?category=games&portname=adgali

(In reply to comment #4)
> Also, the original master site doesn't work for me.
The same here.

(In reply to comment #4)
> Did you mean to replace with, instead of add sourcefiles.org?
I thought about this, but added mirror, because original master site is (was) official location, the DNS name of which registered to 2020-04-16 date:
https://whois.icann.org/en/lookup?name=adgali.apiou.org

I found web archive of the official site:
https://web.archive.org/web/20110918034345/http://adgali.apiou.org/

According to official site, there is a development location at http://savannah.nongnu.org/projects/adgali
But download link "http://savannah.nongnu.org/files/?group=adgali" redirects to the same "http://adgali.apiou.org/download" link, which doesn't work currently.

I attached patch with mirror only, just in case. With following description of changes:
- Update MASTER_SITES to use mirror instead of original location, which is not available currently
- Unbreak fetch
- Regenerate patches
Comment 7 lightside 2016-06-07 13:56:09 UTC
Created attachment 171144 [details]
The poudriere testport log (FreeBSD 10.2 amd64)
Comment 8 lightside 2016-06-07 14:44:55 UTC
Comment on attachment 171143 [details]
Proposed patch (since 416324 revision)

Vladimir Krstulja, please check the patch again.
Comment 9 VK freebsd_triage 2016-06-07 16:19:06 UTC
Comment on attachment 171143 [details]
Proposed patch (since 416324 revision)

The patch applies, the port builds. Implicit approval of it, the port has no maintainer.

Personally, looking at apiou.org, there's no mention of the library. The SF repo hasn't been updated since 2013. If you ask me, this is an abandoned project and the original master site is not coming back.
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-06-09 15:30:21 UTC
A commit references this bug:

Author: arved
Date: Thu Jun  9 15:30:08 UTC 2016
New revision: 416612
URL: https://svnweb.freebsd.org/changeset/ports/416612

Log:
  Make fetchable

  PR:		210033
  Submitted by:	lightside@gmx.com

Changes:
  head/games/adgali/Makefile
Comment 11 Tilman Keskinoz freebsd_committer freebsd_triage 2016-06-09 15:30:32 UTC
committed, thanks