Created attachment 171065 [details] poudriere log Builds fine on Poudriere jail with 10.3-RELEASE/amd64 (attached log). Patch attached.
Created attachment 171066 [details] patch
Created attachment 171067 [details] patch Corrected to remove SVNREV from Makefile - it's not used anymore.
Looks good to me
Comment on attachment 171067 [details] patch Allison, please also approve the patch by flagging it as maintainer-approval+.
+share/man/man1/vbam.1 This is wrong, manpages should be installed to ${PREFIX}/man directory, not ${PREFIX}/share/man.
Created attachment 171616 [details] corrected patch Corrected to use ${PREFIX}/man.
Comment on attachment 171616 [details] corrected patch Bugzilla needs maintainer e-mail for approval request. ;)
Plist problems on 9.x: http://people.freebsd.org/~pawel/buildlogs/visualboyadvance-m-2.0.0b2-9amd64.log Fails to build with clang on amd64: http://people.freebsd.org/~pawel/buildlogs/visualboyadvance-m-2.0.0b2-10amd64.log
Created attachment 172282 [details] vba-m 2.0.0b2 Sorry, it took so long, but I was busy sending other patches :)
Created attachment 172283 [details] poudriere log
Piotr, thanks for your patch. Please request again maintainer-approval(?) (with maintainer email address) on new patches you submit. We use that flag to track maintainer-approved PRs and attachments. Please also note that merely confirming QA (poudriere, portlint) is sufficient. Attaching build logs is not required and only clutters the Bugzilla database.
fails to build on 11a, 12a: http://people.freebsd.org/~pi/logs/emulators__visualboyadvance-m-11a-1471030264.txt http://people.freebsd.org/~pi/logs/emulators__visualboyadvance-m-cur-1471030264.txt
Created attachment 173630 [details] emulators/visualboyadvance-m #include <unistd.h> is required on 11. I didn't check 12, but considering the number of differences between 11 and 12, it should be fine. It also compiles on 10.3.
Thanks, testbuilds are fine with this!
Committed, thanks!
A commit references this bug: Author: pi Date: Sat Aug 13 15:31:44 UTC 2016 New revision: 420162 URL: https://svnweb.freebsd.org/changeset/ports/420162 Log: emulators/visualboyadvance-m: 1.8.0 -> 2.0.0b2 - patted portlint - patches are now makepatch compliant PR: 210058 Changes: http://vba-m.com/forum/showthread.php?tid=1037&pid=6091#pid6091 http://vba-m.com/forum/showthread.php?tid=1036&pid=6090#pid6090 Submitted by: Piotr Kubaj <pkubaj@anongoth.pl> Reviewed by: pawel Approved by: Allison N. Reid <root@cooltrainer.org> (maintainer) Changes: head/emulators/visualboyadvance-m/Makefile head/emulators/visualboyadvance-m/distinfo head/emulators/visualboyadvance-m/files/patch-CMakeLists.txt head/emulators/visualboyadvance-m/files/patch-src-common-Patch.cpp head/emulators/visualboyadvance-m/files/patch-src-common-ffmpeg.cpp head/emulators/visualboyadvance-m/files/patch-src-gba-GBALink.cpp head/emulators/visualboyadvance-m/files/patch-src-sdl-expr.cpp head/emulators/visualboyadvance-m/files/patch-src_common_ConfigManager.cpp head/emulators/visualboyadvance-m/pkg-plist