Bug 210158 - net/ns3: Update to version 3.25
Summary: net/ns3: Update to version 3.25
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-09 07:20 UTC by Nikola Kolev
Modified: 2016-09-13 11:48 UTC (History)
1 user (show)

See Also:


Attachments
ns3-3.25 patch (8.99 KB, patch)
2016-06-09 07:20 UTC, Nikola Kolev
no flags Details | Diff
ns3.25 patch (9.45 KB, patch)
2016-09-07 08:00 UTC, Nikola Kolev
koue: maintainer-approval+
Details | Diff
ns3-v4 (9.44 KB, patch)
2016-09-10 15:04 UTC, Pawel Pekala
no flags Details | Diff
ns3-v5 (33.53 KB, patch)
2016-09-11 11:29 UTC, Pawel Pekala
pawel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2016-06-19 16:26:07 UTC
Fails make check-plist with non-standard options:

http://people.freebsd.org/~pawel/buildlogs/ns3-3.25-10amd64.log
Comment 2 Nikola Kolev 2016-09-06 09:57:42 UTC
Hi Pawel,

Sorry for take me so long but I was quite busy.

I have problem with the updating the port and would to ask for some help. I fixed the problem with non default options but I have another one. # make stage-qa reports few warnings. For example:

Warning: you need USE_GNOME+=pango

pango is dependency only if GTK2 option is enabled. I added:

GTK2_USE_GNOME+=        pango

but it does not seem to work. # make stage-qa produces the same warning. If I add 

USE_GNOME+=pango 

then the warning disappears.

I have same problem with  USE_GNOME+=cairo and USE_GNOME+=gdkpixbuf2. Can you give me some advice?

Btw I cannot enable/disable all options from the ns3 configure script. If the scripts finds some library exists in the system then it will use it during the compilation but for now I can handle this behavior.

Regards,
Nikola
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2016-09-06 12:55:58 UTC
(In reply to Nikola Kolev from comment #2)

Hi Nikola,

>GTK2_USE_GNOME+=        pango
>
>but it does not seem to work. # make stage-qa produces the same warning. 

This particular option helper works in a different way:

${option}_USE=  GNOME=gdkpixbuf2,pango

so it should be:

GTK2_USE= GNOME=gdkpixbuf2,pango

You can verify if option helper is set correctly by:

make -V USE_GNOME OPTIONS_SET=GTK2

All options helpers are documented in /usr/ports/Mk/bsd.options.mk for
future reference and if not sure you can always ask.
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2016-09-08 12:00:08 UTC
There is still plist problem, when DEBUG=on:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/libns%%VERSION%%-traffic-control-test%%DEBUG_SUFX%%.so
===> Error: Plist issues found.
*** Error code 1
Comment 6 Nikola Kolev 2016-09-08 13:30:53 UTC
I've started poudriere with DEBUG=on to see the logs.
I tested on 10.3 and don't have such issue.
Comment 8 Pawel Pekala freebsd_committer freebsd_triage 2016-09-10 15:04:12 UTC
Created attachment 174621 [details]
ns3-v4

I was wrong with DEBUG=on, it should be TEST=on. Anyway I attached patch that fixes this issue and contains few little framework fixes. It would be nice to have pkg-plist sorted.
Comment 9 Pawel Pekala freebsd_committer freebsd_triage 2016-09-11 11:29:08 UTC
Created attachment 174651 [details]
ns3-v5

now with sorted plist
Comment 10 Nikola Kolev 2016-09-13 09:15:10 UTC
Comment on attachment 174651 [details]
ns3-v5

Approved.
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-09-13 11:42:19 UTC
A commit references this bug:

Author: pawel
Date: Tue Sep 13 11:41:21 UTC 2016
New revision: 421994
URL: https://svnweb.freebsd.org/changeset/ports/421994

Log:
  - Update to version 3.25 [1]
  - Register proxy dependencies found by stage-qa [1]
  - Convert LIB_DEPENDS to USES=sqlite and USE_GNOME=libxml2
  - Simplify options helpers
  - Sort pkg-plist

  PR:             210158 [1]
  Submitted by:   Nikola Kolev (maintainer) [1]

Changes:
  head/net/ns3/Makefile
  head/net/ns3/distinfo
  head/net/ns3/pkg-plist