Bug 210223 - [maintainer-update] mail/qmail Add rc.d script for qmails queue management daemons
Summary: [maintainer-update] mail/qmail Add rc.d script for qmails queue management da...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-12 06:42 UTC by erdgeist
Modified: 2016-06-25 16:06 UTC (History)
1 user (show)

See Also:


Attachments
the patch (4.36 KB, patch)
2016-06-12 06:42 UTC, erdgeist
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description erdgeist 2016-06-12 06:42:48 UTC
Created attachment 171322 [details]
the patch

Now a qmailsmtpd and qmailsend rc.d script is installed that allows bringing up the respective sub systems in a FreeBSDly fashion.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-06-25 14:44:34 UTC
A commit references this bug:

Author: pi
Date: Sat Jun 25 14:44:05 UTC 2016
New revision: 417471
URL: https://svnweb.freebsd.org/changeset/ports/417471

Log:
  mail/qmail: Add rc.d script for qmails queue management daemons

  PR:		210223
  Submitted by:	Dirk Engling <erdgeist@erdgeist.org> (maintainer)

Changes:
  head/mail/qmail/Makefile
  head/mail/qmail/files/qmailsend.in
  head/mail/qmail/pkg-plist
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2016-06-25 14:44:43 UTC
Committed, thanks!
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2016-06-25 15:21:02 UTC
I might have missed an obvious thing but I do not understand why have this complex situation playing with @exec/@unexec instead of directly package the symlink in the package itself?

Second please avoid using @exec/@unexec which are not precise: it does not say when it should happen: pre or post phase. prefer @postexec/@preexec/@postunexec/@preunexec
Comment 4 erdgeist 2016-06-25 15:42:16 UTC
(In reply to Baptiste Daroussin from comment #3)

I only recently inherited the port maintainership and just copied the code for the legacy rc link to also handle both, the new rc scripts and properly name the old one.

Until now doing it this way seemed not to be a problem. I can however clean up the pkg list. Is there any documentation for the recent features?
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-06-25 15:44:29 UTC
I think this would be a good start;

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#rc-scripts
Comment 6 erdgeist 2016-06-25 16:06:12 UTC
(In reply to erdgeist from comment #4)

Also creating the rc.d-links has been optional in the past, so it is guarded by a config variable.

I think this had to do with djb 's license demanding all files – including boot scripts – to be placed under /var/qmail.

Maybe it's time to always create the links as I do not see a way to start both sub systems without breaking rc semantics.