Bug 210786 - www/node, www/node4: Use NLS option to enable system-icu
Summary: www/node, www/node4: Use NLS option to enable system-icu
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: patch, patch-ready
Depends on:
Blocks: 210891
  Show dependency tree / graph
 
Reported: 2016-07-03 18:14 UTC by Bradley T. Hughes
Modified: 2016-07-09 13:07 UTC (History)
1 user (show)

See Also:

Attachments
patch from a git commit (2.97 KB, text/plain)
2016-07-03 18:14 UTC, Bradley T. Hughes 		bhughes: maintainer-approval+
Details
patch from a git commit (3.00 KB, patch)
2016-07-07 13:42 UTC, Bradley T. Hughes 		no flags Details | Diff
patch from a git commit (3.01 KB, patch)
2016-07-07 13:52 UTC, Bradley T. Hughes 		bhughes: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley T. Hughes freebsd_committer freebsd_triage 2016-07-03 18:14:34 UTC 
Created attachment 172069 [details]
patch from a git commit

Add the NLS option, which enables the --with-intl=system-icu configure
option and ICU dependency. Bump PORTREVISION due to the new option.
Comment 1 Bradley T. Hughes freebsd_committer freebsd_triage 2016-07-03 18:15:42 UTC 
$ (cd www/node; portlint -C)
looks fine.
$ (cd www/node4; portlint -C)
looks fine.

- testport: OK, poudriere on 10.3-R amd64
Comment 2 Bradley T. Hughes freebsd_committer freebsd_triage 2016-07-07 13:42:36 UTC 
Created attachment 172197 [details]
patch from a git commit

Refreshed patch, ready for commit.
Comment 3 Bradley T. Hughes freebsd_committer freebsd_triage 2016-07-07 13:52:59 UTC 
Created attachment 172198 [details]
patch from a git commit

Fix PORTREVISION snafu in the last patch.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-09 12:30:03 UTC 
testbuilds@work
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-09 12:55:04 UTC 
testbuilds@work
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-07-09 13:06:58 UTC 
A commit references this bug:

Author: pi
Date: Sat Jul  9 13:06:53 UTC 2016
New revision: 418276
URL: https://svnweb.freebsd.org/changeset/ports/418276

Log:
  www/node[4]: Use NLS option to enable system-icu

  PR:		210786
  Submitted by:	Bradley T. Hughes <bradleythughes@fastmail.fm> (maintainer)

Changes:
  head/www/node/Makefile
  head/www/node4/Makefile
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-09 13:07:13 UTC 
committed, thanks!