Bug 210856 - benchmarks/iorate: implicit declaration of function 'gettimeofday' is invalid in C99
Summary: benchmarks/iorate: implicit declaration of function 'gettimeofday' is invalid...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-05 21:00 UTC by Mark Millard
Modified: 2016-09-10 19:21 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback-

Attachments
svn-diff_benchmarks_iorate (1.34 KB, patch)
2016-08-02 17:19 UTC, Walter Schwarzenfeld 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Millard 2016-07-05 21:00:20 UTC 
As reported by the compiler doing the build:

ior_rand.c:47:5: warning: implicit declaration of function 'gettimeofday' is invalid in C99 [-Wimplicit-function-declaration]
    gettimeofday( &tp, 0 );             /* get current time */
    ^

ior_mach.c:666:10: warning: implicit declaration of function 'gettimeofday' is invalid in C99 [-Wimplicit-function-declaration]
    if ( gettimeofday( &tp, 0 ) == -1 ) {
         ^
Comment 1 Mark Millard 2016-08-02 08:35:25 UTC 
The build was of iorate-3.05 --which is still in place as of /usr/ports/ -r419343 .
Comment 2 Walter Schwarzenfeld freebsd_triage 2016-08-02 17:19:41 UTC 
Created attachment 173198 [details]
svn-diff_benchmarks_iorate
Comment 3 Walter Schwarzenfeld freebsd_triage 2016-09-09 17:39:13 UTC 
Maintainer timeout?
Comment 4 Walter Schwarzenfeld freebsd_triage 2016-09-10 17:52:03 UTC 
Test builds with poudriere ok with 103/93 amd64/i386.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-09-10 19:20:45 UTC 
Testbuilds are OK, committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-09-10 19:21:27 UTC 
A commit references this bug:

Author: pi
Date: Sat Sep 10 19:20:45 UTC 2016
New revision: 421728
URL: https://svnweb.freebsd.org/changeset/ports/421728

Log:
  benchmarks/iorate: implicit decl. of function 'gettimeofday' is invalid in C99

  PR:		210856
  Reported by:	Mark Millard <markmi@dsl-only.net>
  Submitted by:	Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
  Approved by:	blttll@gmail.com (maintainer timeout)

Changes:
  head/benchmarks/iorate/files/patch-ior__mach.c
  head/benchmarks/iorate/files/patch-ior__rand.c