Created attachment 172717 [details] libtorrent.diff On some system compiling net-p2p/rtorrent fails with e.g. > /usr/local/lib/libtorrent.so: undefined reference to `SHA1_Update' > /usr/local/lib/libtorrent.so: undefined reference to `SHA1_Final' > /usr/local/lib/libtorrent.so: undefined reference to `RC4' > /usr/local/lib/libtorrent.so: undefined reference to `DH_compute_key' Currently net-p2p/libtorrent itself doesn't link with libcrypto but should. With default options rtorrent likely picks up libcrypto implicitly through one of its dependencies. This fails when non-default options are chosen. The attached patch makes sure that net-p2p/libtorrent links with libcrypto. Please see the linked forum thread for more details. Builds fine in Poudriere in a FreeBSD/i386 9.3 jail. Setting maintainer-approval to + since the port has no maintainer.
Nice work Tobias. In future, non-version update (and in particular bug fix) changes can have merge-quarterly set to ?
Created attachment 173967 [details] Fixes the issues with the first patch Hello, I'm now the maintainer of this port, I've checked your patch, it's a little bit obsolete due to some changes, so I fixed it. Everything builds fine.
A commit references this bug: Author: pi Date: Fri Aug 26 06:38:02 UTC 2016 New revision: 420894 URL: https://svnweb.freebsd.org/changeset/ports/420894 Log: net-p2p/libtorrent: Explicitly link with libcrypto - make sure that net-p2p/libtorrent links with libcrypto PR: 211223 Submitted by: Tobias Kortkamp <t@tobik.me> Approved by: pipfstarrd@opmbx.org (maintainer) Changes: head/net-p2p/libtorrent/Makefile
koobs, about the MFH: there are other changes to HEAD for this port. A MFH would provide additional changes, and a selective MFH would be non-trivial. What would be the recommended approach ? Technically, I think a full merge is still OK, but does that violate the policy for MFH ?