Bug 211321 - sysutils/showbeastie: Fix build on FreeBSD/i386 >= 11.0, mark broken on FreeBSD 9
Summary: sysutils/showbeastie: Fix build on FreeBSD/i386 >= 11.0, mark broken on FreeB...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL: http://beefy10.nyi.freebsd.org/data/1...
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-07-24 00:29 UTC by Tobias Kortkamp
Modified: 2016-08-03 11:19 UTC (History)
3 users (show)

See Also:
tobik: merge-quarterly?


Attachments
showbeastie.diff (768 bytes, patch)
2016-07-24 00:29 UTC, Tobias Kortkamp
tobik: maintainer-approval+
Details | Diff
showbeastie.diff (1.01 KB, patch)
2016-08-01 12:01 UTC, Carlos J. Puga Medina
tobik: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-07-24 00:29:04 UTC
Created attachment 172909 [details]
showbeastie.diff

This fixes the build on FreeBSD/i386 11.0 and HEAD.  This should also go into the quarterly branch.

On FreeBSD 9.3 the port compiles but doesn't run correctly because of how loader logos were handled back then.  It should be marked as broken on FreeBSD 9.

Testbuilds in Poudriere FreeBSD/amd64 10.2 are fine.  I've also tested building the port on a fresh FreeBSD/i386 11.0-BETA2 VM.  portlint passes too (ignoring the expected warning about MASTER_SITES).
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-01 12:01:58 UTC
Created attachment 173157 [details]
showbeastie.diff

We have no master site and no distfiles. Therefore these are empty.
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-01 12:13:05 UTC
Now `portlint -ac' looks fine.
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2016-08-02 02:26:43 UTC
(In reply to Carlos J. Puga Medina from comment #1)
Mentor approved. Also this looks like a build fix blanket per https://wiki.freebsd.org/ports-secteam#Blanket_Approval. Please MFH under the blanket and close appropriately following.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-08-03 11:14:30 UTC
A commit references this bug:

Author: cpm
Date: Wed Aug  3 11:13:31 UTC 2016
New revision: 419508
URL: https://svnweb.freebsd.org/changeset/ports/419508

Log:
  - Fix build on FreeBSD 11.0/i386 and HEAD.
  - Mark BROKEN on 9.3
  - We have no MASTER_SITES and no DISTFILES. Therefore these are empty.

  PR:	211321
  Submitted by:	Tobias Kortkamp (maintainer)
  Reviewed by:	junovitch (mentor)
  Approved by:	junovitch (mentor)
  MFH:		2016Q3 (ports-secteam build fix blanket)

Changes:
  head/sysutils/showbeastie/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-08-03 11:18:32 UTC
A commit references this bug:

Author: cpm
Date: Wed Aug  3 11:17:44 UTC 2016
New revision: 419509
URL: https://svnweb.freebsd.org/changeset/ports/419509

Log:
  MFH: r419508

  - Fix build on FreeBSD 11.0/i386 and HEAD.
  - Mark BROKEN on 9.3
  - We have no MASTER_SITES and no DISTFILES. Therefore these are empty.

  PR:	211321
  Submitted by:	Tobias Kortkamp (maintainer)
  Reviewed by:	junovitch (mentor)
  Approved by:	junovitch (mentor)

  Approved by:	ports-secteam (build fix blanket)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/sysutils/showbeastie/Makefile
Comment 6 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-08-03 11:19:26 UTC
Committed!

Thanks