Bug 211391 - x11-themes/qtcurve-gtk2: NULL pointer dereference causes applications to crash
Summary: x11-themes/qtcurve-gtk2: NULL pointer dereference causes applications to crash
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-26 18:15 UTC by Florian Degner
Modified: 2016-10-22 23:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (makc)

Attachments
Fix NULL pointer dereference in gtkDrawFlatBox() (566 bytes, patch)
2016-07-26 18:15 UTC, Florian Degner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Degner 2016-07-26 18:15:53 UTC 
Created attachment 173014 [details]
Fix NULL pointer dereference in gtkDrawFlatBox()

qtcurve-gtk2 does not rigorously check for the gtk_paint_flat_box() [0] parameter "detail" being NULL. This causes certain applications to segfault. [1]

The attached patch fixes the problem.


[0] https://developer.gnome.org/gtk2/stable/GtkStyle.html#gtk-paint-flat-box
[1] https://bugs.kde.org/show_bug.cgi?id=343704
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-10-22 23:20:40 UTC 
A commit references this bug:

Author: jhale
Date: Sat Oct 22 23:20:21 UTC 2016
New revision: 424491
URL: https://svnweb.freebsd.org/changeset/ports/424491

Log:
  - Fix NULL pointer dereference in gtkDrawFlatBox() in x11-themes/qtcurve-gtk2 [1]
  - Set LICENSE
  - Take maintainership of the qtcurve ports

  PR:		211391 [1]
  Submitted by:	<f.degner@gmx.de> [1]

Changes:
  head/x11-themes/qtcurve/Makefile
  head/x11-themes/qtcurve/files/patch-gtk2_style_qtcurve.c
  head/x11-themes/qtcurve-gtk2/Makefile
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2016-10-22 23:35:28 UTC 
Fixed, thanks!