Bug 211425 - net/freenet6 improvements
Summary: net/freenet6 improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Edwin Groothuis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-28 18:35 UTC by clive
Modified: 2017-06-16 13:50 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (edwin)


Attachments
Patch (2.13 KB, patch)
2016-07-28 18:35 UTC, clive
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description clive 2016-07-28 18:35:25 UTC
Created attachment 173074 [details]
Patch

1. When shutdown, the correct behavior is to send SIGHUP.

2. New patch patch-src__net__icmp_echo_engine.c: When PID of the gw6c process greater than 65536, it can not perform timeout ping check correctly, due to echo_id in icmp_hdr is declared as uint16_t. There should be a better way to deal with it, but since the upstream is closed, so I think for now a workaround in ports should be just fine.

3. New patch patch-template__freebsd.sh: To mute dmesg noise "nd6_dad_timer: cancel DAD on tun0 because of ND6_IFF_IFDISABLED."
Comment 1 Kevin Lo freebsd_committer freebsd_triage 2017-06-16 13:50:10 UTC
Committed, thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-06-16 13:50:15 UTC
A commit references this bug:

Author: kevlo
Date: Fri Jun 16 13:49:29 UTC 2017
New revision: 443692
URL: https://svnweb.freebsd.org/changeset/ports/443692

Log:
  Implement a number of improvments:

  - When shutdown, the correct behavior is to send SIGHUP.
  - When PID of the gw6c process greater than 65536, it can not perform
    timeout ping check correctly, due to echo_id in icmp_hdr is declared as
    uint16_t.
  - Mute dmesg noise "nd6_dad_timer: cancel DAD on tun0 because of
    ND6_IFF_IFDISABLED."

  PR:	211425
  Submitted by:	clive

Changes:
  head/net/freenet6/Makefile
  head/net/freenet6/files/freenet6.in
  head/net/freenet6/files/patch-src_net_icmp__echo__engine.c
  head/net/freenet6/files/patch-template_freebsd.sh