Bug 211426 - net/gogoc improvements
Summary: net/gogoc improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-28 18:39 UTC by clive
Modified: 2017-03-23 12:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (kami)


Attachments
patch (2.34 KB, patch)
2016-07-28 18:39 UTC, clive
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description clive 2016-07-28 18:39:18 UTC
Created attachment 173075 [details]
patch

1. When shutdown, the correct behavior is to send SIGHUP.

2. New patch patch-icmp_echo_engine.c: When PID of the gogoc process greater than 65536, it can not perform timeout ping check correctly, due to echo_id in icmp_hdr is declared as uint16_t. There should be a better way to deal with it, but since the upstream is closed, so I think for now a workaround in ports should be just fine.

3. New patch patch-freebsd.sh: To mute dmesg noise "nd6_dad_timer: cancel DAD on tun0 because of ND6_IFF_IFDISABLED."

4. Leave modified gogoc.conf on uninstall. Don't overwrite gogoc.conf on install.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-23 12:55:26 UTC
A commit references this bug:

Author: robak
Date: Thu Mar 23 12:54:47 UTC 2017
New revision: 436769
URL: https://svnweb.freebsd.org/changeset/ports/436769

Log:
  net/gogoc: new patch with various improvements

  - When shutdown, the correct behavior is to send SIGHUP.
  - New patch patch-icmp_echo_engine.c: When PID of the gogoc process greater
    than 65536, it can not perform timeout ping check correctly, due to
    echo_id in icmp_hdr is declared as uint16_t.
  - New patch patch-freebsd.sh: To mute dmesg noise "nd6_dad_timer: cancel
    DAD on tun0 because of ND6_IFF_IFDISABLED."
  - Don't overwrite gogoc.conf on install.

  PR:		211426
  Submitted by:	Clive Lin <clive@tongi.org>
  Approved by:	maintainer timeout (8 months)

Changes:
  head/net/gogoc/Makefile
  head/net/gogoc/files/gogoc.in
  head/net/gogoc/files/patch-freebsd.sh
  head/net/gogoc/files/patch-icmp_echo_engine.c
  head/net/gogoc/pkg-plist
Comment 2 Bartek Rutkowski freebsd_committer freebsd_triage 2017-03-23 12:56:03 UTC
Committed, thanks!