Bug 211494 - www/nghttp2: Update to 1.14.0 plus sample config and rc.d script
Summary: www/nghttp2: Update to 1.14.0 plus sample config and rc.d script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords: needs-qa, patch
: 211336 211774 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-01 06:12 UTC by Peter Wemm
Modified: 2016-09-11 07:54 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Update to 1.13.0 + rc.d + sample files (5.00 KB, patch)
2016-08-01 06:12 UTC, Peter Wemm 		no flags Details | Diff
svn diff for www/nghttp2 (7.47 KB, patch)
2016-08-15 10:43 UTC, Bernard Spil 		no flags Details | Diff
svn diff for www/nghttp2 (7.47 KB, patch)
2016-08-27 20:13 UTC, Bernard Spil 		brnrd: maintainer-approval? (sunpoet)
 Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Wemm freebsd_committer freebsd_triage 2016-08-01 06:12:22 UTC 
Created attachment 173151 [details]
Update to 1.13.0 + rc.d + sample files

I'm aware of PR#211336 which is an update to 1.13.0.  I'm using an updated version as well and added an rc.d script for nghttpx and a sample config file.

Could you please update it?  Sample rc.d scripts would be appreciated.  I'm sure the one I added in my version of the update patch needs work but it seems to work.
Comment 1 Peter Wemm freebsd_committer freebsd_triage 2016-08-01 07:54:41 UTC 
Hmm. Another thought: does it make sense to split it between the library and the sample servers it contains?  I know of consumers (eg: curl) that use it for the library and have no interest in the servers / startup scripts etc.
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2016-08-04 09:26:20 UTC 
*** Bug 211336 has been marked as a duplicate of this bug. ***
Comment 3 Bernard Spil freebsd_committer freebsd_triage 2016-08-15 10:43:37 UTC 
Created attachment 173698 [details]
svn diff for www/nghttp2

I've combined the patches from bug #211774 and #211494
The options have been moved to the location where the existing ASIO and HPACK options were implemented

Proposed commit log:

> www/nghttp2: Update to 1.13.0
> 
>   - Update to 1.13.0
>   - Switch USE_OPENSSL to USES= ssl
>   - Add options for APPS and SPDY
>   - Default no change (i.e. APPS and SPDY on)
>   - Add rc-script for nghttpx
>  - Add sample config for nghttpx
> 
> PR:   211336, 211494, 211774
> Submitted by:  brnrd (211336, 1.13.0 only)
> Submitted by:  peter (211494, rc-script and sample config)
> Submitted by:  Robert Schulze <rs@bytecamp.net> (211774, APPS and SPDY options)

Tested with default and APPS+SPDY options disabled
https://brnrd.eu/poudriere/data/110libre-default/2016-08-15_12h31m33s/logs/nghttp2-1.13.0.log
Comment 4 Bernard Spil freebsd_committer freebsd_triage 2016-08-15 10:44:08 UTC 
*** Bug 211774 has been marked as a duplicate of this bug. ***
Comment 5 Bernard Spil freebsd_committer freebsd_triage 2016-08-27 20:13:22 UTC 
Created attachment 174135 [details]
svn diff for www/nghttp2

Updated patch to 1.14.0

Proposed commit log
> www/nghttp2: Update to 1.14.0
> 
>  - Update to 1.14.0
>  - Switch USE_OPENSSL to USES= ssl
>  - Add options for APPS and SPDY
>  - Default no change (i.e. APPS and SPDY on)
>  - Add rc-script for nghttpx
>  - Add sample config for nghttpx
> 
> PR:   211336, 211494, 211774
> Submitted by:  brnrd (211336, 1.14.0 only)
> Submitted by:  peter (211494, rc-script and sample config)
> Submitted by:  Robert Schulze <rs@bytecamp.net> (211774, APPS and SPDY options)
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-09-11 07:53:15 UTC 
A commit references this bug:

Author: brnrd
Date: Sun Sep 11 07:52:27 UTC 2016
New revision: 421805
URL: https://svnweb.freebsd.org/changeset/ports/421805

Log:
  www/nghttp2: Update to 1.14.0

    - Update to 1.14.0
    - Switch USE_OPENSSL to USES= ssl
    - Add options for APPS and SPDY
    - Default no change (i.e. APPS and SPDY on)
    - Add rc-script for nghttpx
    - Add sample config for nghttpx

  PR:             211336, 211494, 211774
  Submitted by:   brnrd (211336, version update)
  Submitted by:   peter (211494, rc-script and sample config)
  Submitted by:   Robert Schulze <rs@bytecamp.net> (211774, APPS and SPDY options)
  Approved by:    Maintainer timeout

Changes:
  head/www/nghttp2/Makefile
  head/www/nghttp2/distinfo
  head/www/nghttp2/files/
  head/www/nghttp2/files/nghttpx.conf.sample
  head/www/nghttp2/files/nghttpx.in
  head/www/nghttp2/pkg-plist