Created attachment 173317 [details] add devel/gettext-tools dependency Translators need the devel/gettext-tools port. I was sure it was in here. While here, edit COMMENT to remove one portlint warning, leaving this: WARN: Makefile: no MASTER_SITES found. is it ok? WARN: Makefile: Consider defining LICENSE. WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples. 0 fatal errors and 3 warnings found. That RUN_DEPENDS warning looks like a false positive in portlint, because I sure can't see what it's complaining about.
It is this line, causes the warning: .if ${PORT_OPTIONS:MCJK} RUN_DEPENDS+= ${FONTS_CJK} <== .endif
This would silence it: .if ${PORT_OPTIONS:MCJK} RUN_DEPENDS+= ${LOCALBASE}/share/fonts/TrueType/gkai00mp.ttf:chinese/arphicttf \ ${LOCALBASE}/share/fonts/OTF/ipam.otf:japanese/font-ipa \ ${LOCALBASE}/share/fonts/nanum-ttf/NanumBarunGothic.ttf:korean/nanumfonts-ttf .endif
Or may better: .if ${PORT_OPTIONS:MCJK} MCJK_RUN_DEPENDS+= ${FONTS_CJK} .endif
correct it: .if ${PORT_OPTIONS:MCJK} CJK_RUN_DEPENDS+= ${FONTS_CJK} .endif
Another question: Is there any reason this port uses links1, instead of links? (links1 had tons of warnings). It is the only port still using links1.
links1 is used to produce text output. A while back, I compared the output from several text-mode browsers, and there were differences. However, at this point, I don't recall specifics. Another text browser could be used, but the doc toolchain would probably require modification because of different text output.
Created attachment 173594 [details] fix path to gettext-tools, portlint complaints
Q/A tests: builds, installs, deinstalls, cleans, portlint thinks it's adequate with hints of almond.
Comment on attachment 173594 [details] fix path to gettext-tools, portlint complaints Approved to (ports) commit Please include this issue ID in the commit log message, along with MFH: 2016Q3, so that the mfh request can be made
A commit references this bug: Author: wblock Date: Fri Aug 12 15:37:42 UTC 2016 New revision: 420130 URL: https://svnweb.freebsd.org/changeset/ports/420130 Log: Add missing gettext-tools dependency. PR: 211597 Approved by: koobs MFH: 2016Q3 Sponsored by: iXsystems Changes: head/textproc/docproj/Makefile
Not closed until MFH is committed When ports-secteam approve (you'll receive an email), you are free to merge (use Tools/scripts/mfh) Ping if you're unsure/have questions
A commit references this bug: Author: wblock Date: Fri Aug 19 17:23:34 UTC 2016 New revision: 420480 URL: https://svnweb.freebsd.org/changeset/ports/420480 Log: MFH: r420130 Add missing gettext-tools dependency. PR: 211597 Approved by: koobs Sponsored by: iXsystems Approved by: ports-secteam (blanket) Changes: _U branches/2016Q3/ branches/2016Q3/textproc/docproj/Makefile
Thanks to koobs (and the HYPNO-TOAD!).