Bug 211657 - devel/rbenv: Compile the optional C extension to speed up rbenv
Summary: devel/rbenv: Compile the optional C extension to speed up rbenv
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-08 09:27 UTC by Jose Luis Duran
Modified: 2016-08-18 16:47 UTC (History)
2 users (show)

See Also:
meta: maintainer-feedback+

Attachments
Patch with proposed improvement (10.67 KB, text/plain)
2016-08-08 09:27 UTC, Jose Luis Duran 		no flags Details
Proposed patch 2 (11.10 KB, text/plain)
2016-08-08 20:36 UTC, Jose Luis Duran 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran 2016-08-08 09:27:54 UTC 
Created attachment 173395 [details]
Patch with proposed improvement

I have another improvement to the devel/rbenv port: compile the realpath C extension to speed up rbenv across the board (https://github.com/rbenv/rbenv/releases/tag/v1.0.0).

The version of shobj-conf currently included in rbenv is a little old, and doesn't support FreeBSD 1x, so I submitted a PR with the latest version: https://github.com/rbenv/rbenv/pull/922 (merged)

In the next rbenv release we won't need the patch.
Comment 1 Jose Luis Duran 2016-08-08 20:36:10 UTC 
Created attachment 173422 [details]
Proposed patch 2

This includes a FreeBSD-specific configure option (patch also submitted upstream).

I wonder if this needs a GPLv3 license option?
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2016-08-17 04:06:31 UTC 
(In reply to Jose Luis Duran from comment #1)

I'm not sure about the license. But I approve others.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-08-18 16:47:25 UTC 
A commit references this bug:

Author: pawel
Date: Thu Aug 18 16:47:09 UTC 2016
New revision: 420411
URL: https://svnweb.freebsd.org/changeset/ports/420411

Log:
  - Compile the realpath C extension to speed up rbenv across the board
  - The version of shobj-conf currently included in rbenv is a little old,
    and doesn't support FreeBSD 1x, include newer version. Upstreamed:

    https://github.com/rbenv/rbenv/pull/922

  PR:		211657
  Submitted by:	Jose Luis Duran
  Approved by:	Koichiro IWAO (maintainer)

Changes:
  head/devel/rbenv/Makefile
  head/devel/rbenv/files/
  head/devel/rbenv/files/patch-src_configure
  head/devel/rbenv/files/patch-src_shobj-conf
  head/devel/rbenv/pkg-plist