Bug 211769 - devel/kdesvn-kde4 - Edit Bookmarks dialogue box missing
Summary: devel/kdesvn-kde4 - Edit Bookmarks dialogue box missing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: David Naylor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-12 10:57 UTC by Taceant Omnes
Modified: 2016-12-19 14:04 UTC (History)
2 users (show)

See Also:


Attachments
Running on FreeBSD 10.3 (61.42 KB, image/png)
2016-08-17 20:16 UTC, David Naylor
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Taceant Omnes 2016-08-12 10:57:26 UTC
Clicking on Bookmarks/Edit Bookmarks I was expecting a dialogue box to appear. That does not happen. This issue is repeatable.

I am running XFCE desktop on FreeBSD 11.0-Beta4.
Comment 1 David Naylor freebsd_committer freebsd_triage 2016-08-17 20:16:14 UTC
Created attachment 173798 [details]
Running on FreeBSD 10.3

Unforunately it is working on my machine.  So "remote" debugging is required.  Would you please run `kdesvn` from a console and report the output.  Also, when I tried to open the edit bookmark dialog it did take a moment or two before it appeared (we could only be so lucky).
Comment 2 Taceant Omnes 2016-08-18 17:06:52 UTC
Hi David,

Thanks for taking an interest on this.

I clicked on Edit Bookmarks and nothing happened, and nothing appeared on the terminal (see below). As I said, I am running XFCE. Could it be the reason for the problem is that I am not running KDE as you seem to be? On Linux however I also do not run KDE and kdesvn works fine.

-----------------------

$ ps -auxww | grep kde
bubblegum    28899   0.0  1.0  180096  30000  -  Is   06:36      0:00.05 kdeinit4: kdeinit4 Running... (kdeinit4)
bubblegum    28900   0.0  1.2  215468  35840  -  I    06:36      0:00.09 kdeinit4: kdeinit4: klauncher --fd=8 (kdeinit4)
bubblegum    28902   0.0  1.4  303400  42528  -  S    06:36      0:00.90 kdeinit4: kdeinit4: kded4 (kdeinit4)
bubblegum    32351   0.0  0.1   14796   2056  5  S+   17:50      0:00.00 grep kde
$ which kdesvn
/usr/local/bin/kdesvn
$ kdesvn
$
Comment 3 Taceant Omnes 2016-08-19 09:24:13 UTC
I have installed kdesvn with pkg. If that helps I can uninstall it and build it from source with changed make options to enable debug, if such a thing exists, but you would need to tell me what options to use.
Comment 4 David Naylor freebsd_committer freebsd_triage 2016-08-20 12:47:31 UTC
I also use pkg, and prefer to fix pkg (as that is a the "normal" user experience).  

Would you please:
$ pkg update  # ensure all your packages are up to date.  Sometimes different versions can cause issues
$ kdebugdialog  # ensure all debugging messages for KDE are running (i.e. "select all")
$ rm .xsession-errors  # clear log messages
$ kdesvn  # open "Edit Bookmarks" dialog, then exit app
$ bugzilla < .xsession-errors  # please post the ".xsession-errors" file this bug report

P.S. I don't think bugzilla is an actual command, just thought it a fun way to describe the steps :-P
Comment 5 Taceant Omnes 2016-08-22 15:50:58 UTC
(In reply to David Naylor from comment #4)


Would you please:
$ pkg update  # ensure all your packages are up to date.  Sometimes different versions can cause issues

---
Done. My /etc/pkg/FreeBSD.conf is configured for "latest".

$ kdebugdialog  # ensure all debugging messages for KDE are running (i.e. "select all")

---
Done. I had to do this: "pkg install kde-runtime" in order to install kdebugdialog. I selected all. The tickbox "Disable all debug output" is _not_ set.

$ rm .xsession-errors  # clear log messages

---
There was no such file.

$ kdesvn  # open "Edit Bookmarks" dialog, then exit app

---
Done.

$ bugzilla < .xsession-errors  # please post the ".xsession-errors" file this bug report

---
There still is no file ".xsession-errors" in the current folder which is my user home folder (I have .ssh, .xinitrc and many others) so I cannot give it you. Any ideas?
Comment 6 Taceant Omnes 2016-08-23 10:55:41 UTC
At the bottom of this Hanbook page ([1]) it says that Xfce can be started by typing startx, or by using XDM. I use the former method, i. e., startx. The fact that I am not using a display manager may possibly explain why the file ".xsession-errors" does not exist. 

All the programs I have tried so far work well (Geany, Firefox, Libreoffice, Tomboy, Thunar, etc). Kdesvn is the only one I have a problem with, and only with the Edit Bookmarks dialogue box, everything else seems to be working. This is indeed a strange issue.

That said this is a minor issue because there is a workaround, which is to use the other entries of the Bookmarks menu which all work!

---
[1] https://www.freebsd.org/doc/handbook/x11-wm.html
Comment 7 Taceant Omnes 2016-08-24 14:13:04 UTC
(In reply to David Naylor from comment #1)

David: just noticed that you are running v. 10.3 while I am running 11.0-RC1.
Comment 8 David Naylor freebsd_committer freebsd_triage 2016-08-30 06:56:40 UTC
I'll be able to investigate further from next month.  In the interim, would you be willing to install enough of KDE to run a KDE session (with login from KDM).  That should, at least, give us a detailed .xsession-errors file.
Comment 9 David Naylor freebsd_committer freebsd_triage 2016-09-17 17:35:43 UTC
I've updated my system to 11-RC2 and, although I cannot reproduce this error, I do not get a dialog box for "Add Bookmark", or for "Ctrl+B".  I'll investigate further.
Comment 10 Tobias C. Berner freebsd_committer freebsd_triage 2016-12-17 09:45:27 UTC
You probably need binm/keditbookmarks installed by x11/kde4-baseapps.
Comment 11 David Naylor freebsd_committer freebsd_triage 2016-12-18 17:00:27 UTC
@Taceant: please check that you have keditbookmarks installed:
# which /usr/local/bin/keditbookmarks
Comment 12 Taceant Omnes 2016-12-19 11:18:59 UTC
Thanks Tobias and David. I did "pkg install kde-baseapps" and after that clicking on "Bookmarks/Edit Bookmarks" works, I do get the bookmarks editor. Problem solved.

But, funny thing...

Clicking on "Bookmarks/Add Bookmark" or typing Ctrl-B stopped working as reported by David in comment #9. I believe it was working previously because I had added a number of bookmarks.

In a nutshell: one problem was fixed but its solution created a new one!

I am still using XFCE (not KDE).

What to do next? 
> Should kde-baseapps be a dependency of kdesvn?
> Should I file a new bug report about "Bookmarks/Add Bookmark" not working?
Comment 13 David Naylor freebsd_committer freebsd_triage 2016-12-19 13:13:23 UTC
Testing a bit further and it appears that with keditbookmarks everything is working:
 a) Adding a bookmark works: although no dialog box opens (is one supposed to?) a bookmark is added.
 b) Opening and editing bookmarks works, and
 c) Creating bookmark folders, and adding bookmarks to that folder, works

I'll commit a fix shortly
Comment 14 David Naylor freebsd_committer freebsd_triage 2016-12-19 13:20:11 UTC
Fixed, thanks :-)
Comment 15 commit-hook freebsd_committer freebsd_triage 2016-12-19 13:20:37 UTC
A commit references this bug:

Author: dbn
Date: Mon Dec 19 13:19:52 UTC 2016
New revision: 428930
URL: https://svnweb.freebsd.org/changeset/ports/428930

Log:
  devel/kdesvn-kde4: fix bookmarks in non-KDE environments.

   - Add missing dependency to kde-baseapps that provides keditbookmarks that
     provides the Bookmarks functionality. [1]
   - Add license file and fix license version.
   - Add missing dependencies (reported by stage-qa).

  PR:		211769
  Suggested by:	tcberner

Changes:
  head/devel/kdesvn-kde4/Makefile
Comment 16 Taceant Omnes 2016-12-19 14:04:27 UTC
I was wrong in my comment #12, I retested and the Add Bookmark feature works, weather by clicking on the menu or typing Ctrl-B. Moreover I booted in Linux (Fedora 24) and the kdesvn behaviour for adding a bookmark is the same as in FreeBSD, i. e. an empty (blank) bookmark is added.

Thanks for the dependency fix.