Bug 211833 - devel/qca: correct build without SHA-0
Summary: devel/qca: correct build without SHA-0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Raphael Kubo da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-14 10:34 UTC by Matthew Rezny
Modified: 2016-08-22 10:35 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback+
rakuco: merge-quarterly+

Attachments
make advertisement of SHA-0 support conditional (793 bytes, patch)
2016-08-14 10:34 UTC, Matthew Rezny 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2016-08-14 10:34:39 UTC 
Created attachment 173658 [details]
make advertisement of SHA-0 support conditional

The patch to build without SHA-0 support neglected to remove sha0 from the list of supported algorithms. The attached patch corrects that oversight.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-08-16 20:32:38 UTC 
Thanks; I'm going to commit this. I also submitted the fix upstream: https://git.reviewboard.kde.org/r/128700/
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-08-16 20:36:31 UTC 
A commit references this bug:

Author: rakuco
Date: Tue Aug 16 20:36:04 UTC 2016
New revision: 420303
URL: https://svnweb.freebsd.org/changeset/ports/420303

Log:
  Adjust the SHA0 removal patch.

  The upstream fix was still returning "sha0" in all_hash_types() even when SHA0
  support is not present. The fix has also been submitted upstream.

  PR:		211833
  Submitted by:	matthew@reztek.cz
  MFH:		2016Q3

Changes:
  head/devel/qca/Makefile
  head/devel/qca/files/patch-plugins_qca-ossl_qca-ossl.cpp
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-18 11:52:07 UTC 
Assign to committer that resolved
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-08-22 10:28:04 UTC 
A commit references this bug:

Author: rakuco
Date: Mon Aug 22 10:27:01 UTC 2016
New revision: 420596
URL: https://svnweb.freebsd.org/changeset/ports/420596

Log:
  MFH: r417968 r418048 r420303

  devel/qca: Fix building without SSLv3 and SHA-0

    - Add 2 patches from upstream project
      - Fix building when libssl does not have SSLv3
      - Fix building when libcrypto does not have SHA-0
    - Replace USE_OPENSSL with USES= ssl
    - Rework files/patch-libressl with `make makepatch`

  Tested with devel/qca and devel/qca-qt5

  PR:		210053
  Approved by:	Maintainer time-out
  Obtained from:	KDE
  Differential Revision:	D6885

  devel/qca: Fix build failure on 9.3 / OpenSSL 0.9.7

    - Re-add patch for compression to satisfy 0.9.7

  PR:		210053

  Adjust the SHA0 removal patch.

  The upstream fix was still returning "sha0" in all_hash_types() even when SHA0
  support is not present. The fix has also been submitted upstream.

  PR:		211833
  Submitted by:	matthew@reztek.cz

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/devel/qca/Makefile
  branches/2016Q3/devel/qca/files/patch-libressl
  branches/2016Q3/devel/qca/files/patch-plugins_qca-ossl_CMakeLists.txt
  branches/2016Q3/devel/qca/files/patch-plugins_qca-ossl_qca-ossl.cpp