Bug 211886 - games/stonesoup: enable LUA by default
Summary: games/stonesoup: enable LUA by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-16 00:39 UTC by Nikolai Lifanov
Modified: 2016-08-18 10:05 UTC (History)
1 user (show)

See Also:


Attachments
games/stonesoup: enable LUA by default (1.22 KB, patch)
2016-08-16 00:39 UTC, Nikolai Lifanov
lifanov: maintainer-approval+
Details | Diff
games/stonesoup: clean up and enable LUA, enable verbose build (1.42 KB, patch)
2016-08-17 17:33 UTC, Nikolai Lifanov
lifanov: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolai Lifanov 2016-08-16 00:39:45 UTC
Created attachment 173720 [details]
games/stonesoup: enable LUA by default

Enable Lua user scripts by default. The game uses and requires Lua already, user scripts can't be used to cheat on shared servers, the upstream default is to enable them, and not having support for Lua user scripts is confusing to users, since widely-advertised features like autofight and automagic don't work. While here, don't install Lua user scripts if Lua user scripts support is disabled.

autofight not working reported by Dmitry Sarkisov in a private email.
Comment 1 Nikolai Lifanov 2016-08-17 17:33:20 UTC
Created attachment 173793 [details]
games/stonesoup: clean up and enable LUA, enable verbose build

Enable verbose build now that there is an upcoming policy to do this.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-18 09:29:33 UTC
While here, is the patch under files/ really needed any longer? Seems like it can be upstreamed or removed. Also I'd suggest to add MAKE_ARGS=     V=1 to verbosify build. Otherwise looks good and builds file, awaiting maintainer's feedback.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-18 09:54:12 UTC
(In reply to Dmitry Marakasov from comment #2)
> While here, is the patch under files/ really needed any longer? Seems like
> it can be upstreamed or removed. Also I'd suggest to add MAKE_ARGS=     V=1
> to verbosify build. Otherwise looks good and builds file, awaiting
> maintainer's feedback.

Oops, that belonged to some other PR.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-08-18 10:05:45 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Aug 18 10:05:06 UTC 2016
New revision: 420394
URL: https://svnweb.freebsd.org/changeset/ports/420394

Log:
  - Enable LUA by default
  - Unconditionally verbosify build

  PR:		211886
  Submitted by:	lifanov@mail.lifanov.com (maintainer)

Changes:
  head/games/stonesoup/Makefile
  head/games/stonesoup/pkg-plist