Bug 212154 - textproc/source-highlight: Fix problem with bash completion file
Summary: textproc/source-highlight: Fix problem with bash completion file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Lo
URL: https://forums.freebsd.org/threads/57...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-08-25 17:13 UTC by Tobias Kortkamp
Modified: 2016-08-26 01:38 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kevlo)

Attachments
source-highlight.diff (6.34 KB, patch)
2016-08-25 17:13 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (kevlo)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-08-25 17:13:27 UTC 
Created attachment 174068 [details]
source-highlight.diff

The run dependency for BASH declares a dependency on ${LOCALBASE}/etc/bash_completion which is never installed by shells/bash-completion, so the build will fail when BASH=on.  Also see the linked forum thread.

We could fix the run dependency, or remove the BASH option all together and always install the bash completion file.  It's not a generated file and is very small.  IMHO it's not worth having the option in the first place, so I removed it.  I've also cleaned up other things in the port, so that portlint is happy with the port again.

portlint ok, poudriere testport FreeBSD 10.2/amd64 ok
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-08-26 01:03:26 UTC 
A commit references this bug:

Author: kevlo
Date: Fri Aug 26 01:02:37 UTC 2016
New revision: 420884
URL: https://svnweb.freebsd.org/changeset/ports/420884

Log:
  Fix the run dependency and install the bash completion file.

  PR:	212154
  Submitted by:	Tobias Kortkamp <t@tobik.me>

Changes:
  head/textproc/source-highlight/Makefile
  head/textproc/source-highlight/files/patch-configure
  head/textproc/source-highlight/files/patch-gl_getopt.in.h
  head/textproc/source-highlight/files/patch-gl_stdbool.in.h
  head/textproc/source-highlight/files/patch-src-cmdline.c
  head/textproc/source-highlight/files/patch-stdbool.in.h
  head/textproc/source-highlight/files/patch-tests_Makefile.in
  head/textproc/source-highlight/pkg-plist
Comment 2 Kevin Lo freebsd_committer freebsd_triage 2016-08-26 01:38:20 UTC 
Committed, thanks.