Bug 212261 - x11/xsel-conrad: Fix memory leak
Summary: x11/xsel-conrad: Fix memory leak
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-08-30 15:39 UTC by Tobias Kortkamp
Modified: 2016-11-03 21:26 UTC (History)
0 users

See Also:
tobik: merge-quarterly?

Attachments
xsel-conrad.diff (3.84 KB, patch)
2016-08-30 15:39 UTC, Tobias Kortkamp 		tobik: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-08-30 15:39:50 UTC 
Created attachment 174217 [details]
xsel-conrad.diff

This brings in a patch from the OpenBSD port x11/xsel which fixes a memory leak in x11/xsel-conrad.  The port hasn't been touched in a while, so I also tried to clean it up a little.

I've submitted a pull request for the memory leak at https://github.com/kfish/xsel/pull/18.  The NUM_TARGETS fix is already in.

Poudriere testport 9.3/i386, 10.3/amd64, 11.0-RC2/amd64 ok, portlint ok

OpenBSD commit:
---------------------
PatchSet 11 
Date: 2014/07/07 10:25:16
Author: sthen
Branch: HEAD
Tag: OPENBSD_5_7_BASE 
Log:
add patches from patrick keshishian:

- fix issue where NUM_TARGETS in main() is incremented one too many times.
- plug memory leak in handle_targets() where copy of supported_targets created
to be passed to change_property() -> XChangeProperty() but not free()-ed.

Members: 
	Makefile:1.8->1.9 
	patches/patch-xsel_c:1.1->1.2
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2016-08-30 15:39:50 UTC 
Maintainer informed via mail
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-11-03 06:01:31 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Nov  3 06:00:54 UTC 2016
New revision: 425189
URL: https://svnweb.freebsd.org/changeset/ports/425189

Log:
  x11/xsel-conrad: minor fixes

  - Plug memory leak [1]
  - Convert to USES=localbase
  - Drop unused X11 dependencies
  - Unsilence install commands
  - Convert DOCS to target helpers
  - Reorder some lines

  PR:		212261
  Submitted by:	Tobias Kortkamp <t@tobik.me>
  Obtained from:	OpenBSD Ports [1]
  Approved by:	maintainer timeout (2 months)
  MFH:		2016Q4

Changes:
  head/x11/xsel-conrad/Makefile
  head/x11/xsel-conrad/files/
  head/x11/xsel-conrad/files/patch-xsel.c
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-11-03 06:02:57 UTC 
Thanks. Landed with minor changes.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-11-03 21:26:01 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Nov  3 21:25:20 UTC 2016
New revision: 425273
URL: https://svnweb.freebsd.org/changeset/ports/425273

Log:
  MFH: r425189

  x11/xsel-conrad: minor fixes

  - Plug memory leak [1]
  - Convert to USES=localbase
  - Drop unused X11 dependencies
  - Unsilence install commands
  - Convert DOCS to target helpers
  - Reorder some lines

  PR:		212261
  Submitted by:	Tobias Kortkamp <t@tobik.me>
  Obtained from:	OpenBSD Ports [1]
  Approved by:	maintainer timeout (2 months)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/x11/xsel-conrad/Makefile
  branches/2016Q4/x11/xsel-conrad/files/