Bug 212316 - [patch] converters/p5-Sereal and others: update to 3.015 and take maintainership
Summary: [patch] converters/p5-Sereal and others: update to 3.015 and take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jun Kuriyama
URL: http://www.freshports.org/converters/...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-01 19:22 UTC by Adam Weinberger
Modified: 2016-09-15 02:04 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kuriyama)


Attachments
3.015 (3.14 KB, patch)
2016-09-01 19:22 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2016-09-01 19:22:58 UTC
Created attachment 174297 [details]
3.015

Hi Jun,

The attached patch updates the p5-Sereal ports to 3.015.

The Changes here are:
  * Fix builds under 5.25+
  * Fix various buffer overun bugs found using AFL (thanks to dgryski)
  * Fix issue in decode_from_file()


-----------------
-----------------
And, Jun, let's talk about maintainership.

Correct me if I'm wrong, but you don't seem particularly interested in the p5-Sereal ports. No commits for nearly 2 years, and all the update work has been done by me and committed under timeouts.

I'm ready and willing to take maintainership of these ports. On every other update I've sent you a total of 6 (SIX) direct emails reiterating this same information and asking for input. Those letters have always gone ignored.

At the end of time out here, I will reassign p5-Sereal* to myself as part of the update, unless you initiate a dialogue with me and we come up with a different plan together.
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2016-09-01 19:33:45 UTC
Adding URL showing recent commit history.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-09-15 02:03:42 UTC
A commit references this bug:

Author: adamw
Date: Thu Sep 15 02:02:49 UTC 2016
New revision: 422176
URL: https://svnweb.freebsd.org/changeset/ports/422176

Log:
  Update p5-Sereal and friends to 3.015.

  While here, a number of Makefile tweaks, including a little
  more info in the descrs, meta::cpan instead of cpan for WWW,
  and a number of formatting tweaks.

  Also, given that p5-Sereal, -Decoder, and -Encoder all have
  the same tests, it's really no benefit to making -Decoder
  and -Encoder register TEST_DEPENDS on each other. Tests for
  just that module work for 'make test', and the full suite
  can be run by doing 'make test' in the main p5-Sereal port.

  Also, take maintainership. This is the third PR that's timed
  out, and I have sent multiple direct emails with each one.
  kuriyama's last commit to this port was nearly 2 years ago.
  I am considering this port abandoned. I'd like to thank
  kuriyama for creating these ports and looking after them
  for over 3 and a half years!

  PR:		212316
  Approved by:	maintainer timeout

Changes:
  head/converters/p5-Sereal/Makefile
  head/converters/p5-Sereal/distinfo
  head/converters/p5-Sereal/pkg-descr
  head/converters/p5-Sereal-Decoder/Makefile
  head/converters/p5-Sereal-Decoder/distinfo
  head/converters/p5-Sereal-Decoder/pkg-descr
  head/converters/p5-Sereal-Encoder/Makefile
  head/converters/p5-Sereal-Encoder/distinfo
  head/converters/p5-Sereal-Encoder/pkg-descr
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2016-09-15 02:04:38 UTC
Committed, along with the maintainer change. Thank you for creating these ports, Jun, and for looking after them for over 3.5 years!