Bug 212404 - x11-toolkits/scintilla & editors/scite: Update to 3.6.7
Summary: x11-toolkits/scintilla & editors/scite: Update to 3.6.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-06 06:06 UTC by lightside
Modified: 2016-09-07 16:41 UTC (History)
1 user (show)

See Also:
cyberbotx: maintainer-feedback+


Attachments
Proposed patch for x11-toolkits/scintilla (since 418359 revision) (5.32 KB, patch)
2016-09-06 06:06 UTC, lightside
cyberbotx: maintainer-approval+
Details | Diff
Proposed patch for editors/scite (since 418359 revision) (2.63 KB, patch)
2016-09-06 06:08 UTC, lightside
cyberbotx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2016-09-06 06:06:48 UTC
Created attachment 174407 [details]
Proposed patch for x11-toolkits/scintilla (since 418359 revision)

Patch to update x11-toolkits/scintilla and editors/scite ports from 3.6.6 to 3.6.7 version.

Look following link for changes:
http://www.scintilla.org/ScintillaHistory.html

x11-toolkits/scintilla:
- Silence mkdir
- Adapt files/patch-makefile, including addition of "-soname" linker option to create SONAME for scintilla libraries, found by stage-qa
- Adapt do-install target
- Adapt pkg-plist

editors/scite:
- Adapt files/patch-makefile

The build tested on FreeBSD 10.2 amd64.
Comment 1 lightside 2016-09-06 06:08:17 UTC
Created attachment 174408 [details]
Proposed patch for editors/scite (since 418359 revision)
Comment 2 lightside 2016-09-06 06:09:09 UTC
Comment on attachment 174407 [details]
Proposed patch for x11-toolkits/scintilla (since 418359 revision)

Excerpt from stage-qa output, before SONAME fix:
-8<--
====> Running Q/A tests (stage-qa)
Warning: /usr/ports/x11-toolkits/scintilla/work/stage/usr/local/lib/libscintilla.so.2 doesn't have a SONAME.
Warning: pkg(8) will not register it as being provided by the port.
Warning: If another port depend on it, pkg will not be able to know where it comes from.
Warning: It is directly in /usr/local/lib, it is probably used by other ports.
Warning: /usr/ports/x11-toolkits/scintilla/work/stage/usr/local/lib/libscintilla_lexers.so.2 doesn't have a SONAME.
Warning: pkg(8) will not register it as being provided by the port.
Warning: If another port depend on it, pkg will not be able to know where it comes from.
Warning: It is directly in /usr/local/lib, it is probably used by other ports.
-->8-

This may require to bump PORTREVISION for dependent ports.
The MAJOR, AGE and REVISION used as names for variables, found in ltmain.in script of libtool:
http://git.savannah.gnu.org/cgit/libtool.git/tree/build-aux/ltmain.in?h=v2.4.6#n6990
Possible to rename them, if needed.
The specified values for MAJOR, AGE and REVISION may be clarified, but I used current values.
Comment 3 Naram Qashat 2016-09-06 06:14:47 UTC
I'm fine with this update and the changes involved.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-09-07 16:39:07 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Sep  7 16:38:52 UTC 2016
New revision: 421511
URL: https://svnweb.freebsd.org/changeset/ports/421511

Log:
  - Update to 3.6.7 (changes: http://www.scintilla.org/ScintillaHistory.html)
  - Silence mkdir
  - Add "-soname" linker option to create SONAME for scintilla libraries (fixes stage-qa)

  PR:		212404
  Submitted by:	lightside@gmx.com
  Approved by:	cyberbotx@cyberbotx.com (maintainer)

Changes:
  head/x11-toolkits/scintilla/Makefile
  head/x11-toolkits/scintilla/distinfo
  head/x11-toolkits/scintilla/files/patch-makefile
  head/x11-toolkits/scintilla/pkg-plist
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-09-07 16:40:09 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Sep  7 16:39:19 UTC 2016
New revision: 421512
URL: https://svnweb.freebsd.org/changeset/ports/421512

Log:
  - Update to 3.6.7

  PR:		212404
  Submitted by:	lightside@gmx.com
  Approved by:	cyberbotx@cyberbotx.com (maintainer)

Changes:
  head/editors/scite/Makefile
  head/editors/scite/distinfo
  head/editors/scite/files/patch-makefile