Created attachment 174513 [details] patch snort2pfcd v0.5 to v0.7 All sources now available at: https://github.com/onestsam/snort2pfcd
Created attachment 174514 [details] patch snort2pfcd v0.5 to v0.7
Created attachment 174515 [details] patch snort2pfcd v0.5 to v0.7
- Does not patch: ===> Applying FreeBSD patches for snort2pfcd-0.7 1 out of 1 hunks failed--saving rejects to Makefile.rej => Patch patch-Makefile failed to apply cleanly. - Patch to rc script is invalid: please do not hardcode /usr/local and please stick to indentation with tabs. - Please use WWW: <url> in pkg-descr to specify homepage.
Created attachment 174568 [details] patch snort2pfcd v0.5 to v0.7 made your changes. try now.
Please test your ports with poudriere and portlint. - Patching is broken - Installation is probably broken too as you've removed PLIST_FILES - Newline is needed before WWW:
Created attachment 174620 [details] patch snort2pfcd v0.5 to v0.7 Very sorry about this. Im a noob when it comes to porting. Should be fixed now. Sorry for any frustration.
portlint: WARN: Makefile: Consider defining LICENSE. 0 fatal errors and 1 warning found. I believe the problem was I hadn't set the N flag for diff.
Mr. Marakasov, I uploaded a new patch. Can you let me know if it works? Samee Shahzada
Created attachment 174719 [details] Patch to update security/snort2pfcd to 0.7 Hi Samee, The patch is getting better - thank you for tidying it up! I have attached an updated patch. The only difference here is that this patch was made with the diff being relative to the main ports tree directory. $ cd /usr/ports $ svn diff security/snort2pfcd > ~/snort2pfcd-0.7.patch As for the LICENSE warning given by portlint, that is because you have not defined what license this software released with. You should perform 3 steps: 1. Decide what license the code should be. This should take into account any parts of the code that were borrowed, copied or forked from other software. It should generally include the license and copyright of that original code, along with your own copyright. It generally makes sense to release the code under the same license, and in the case of the GPL it is mandated by the license itself. 2. Add a file called COPYING into the root directory of you source, with the details of the license. Look at examples of other code on GitHub, or at the software from which this code is derived, if it is not all original. 3. Add lines to your port which outline the license and which file contains further details. For example, if you choose the GPLv2: COMMENT= Snort alert to pf blocker +LICENSE= GPLv2 +LICENSE_FILE= ${WRKSRC}/COPYING LIB_DEPENDS= libcidr.so:devel/libcidr I hope that helps! -Ben PS: You should try to tag the current commit of your GitHub code with the release version, so that it shows here: https://github.com/onestsam/snort2pfcd/releases
Approved
How do I approve it. Its approved. Should I just say "approved?"
Committed, with a few differences. See the differential review link for details. Thanks for the updated version Samee.
A commit references this bug: Author: woodsb02 Date: Sun Sep 18 11:58:39 UTC 2016 New revision: 422380 URL: https://svnweb.freebsd.org/changeset/ports/422380 Log: security/snort2pfcd: Update to 0.7 - Add LICENSE=NONE as no license has been defined upstream - Remove patch-Makefile as it has been upstreamed PR: 212481 Submitted by: onestsam@gmail.com (maintainer) Reviewed by: amdmi3 Approved by: mat (mentor) Differential Revision: https://reviews.freebsd.org/D7908 Changes: head/security/snort2pfcd/Makefile head/security/snort2pfcd/distinfo head/security/snort2pfcd/files/patch-Makefile head/security/snort2pfcd/pkg-descr