Bug 212773 - [NEW PORT] net/pecl-oauth2: Php Interface to the OAuth Protocol
Summary: [NEW PORT] net/pecl-oauth2: Php Interface to the OAuth Protocol
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-17 17:25 UTC by Danilo G. Baio
Modified: 2016-10-10 20:14 UTC (History)
2 users (show)

See Also:


Attachments
pecl-oauth2.shar (1.79 KB, text/plain)
2016-09-17 17:25 UTC, Danilo G. Baio
no flags Details
pecl-oauth2-v02.shar (1.82 KB, text/plain)
2016-09-27 20:40 UTC, Danilo G. Baio
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo G. Baio freebsd_committer freebsd_triage 2016-09-17 17:25:34 UTC
Created attachment 174883 [details]
pecl-oauth2.shar

pecl-oauth is a php interface to the oauth protocol.
Oauth is an authorization protocol built on top of
HTTP which allows applications to securely access
data without having to store usernames and passwords.

WWW: http://pecl.php.net/package/oauth/

This version is specific to php70 compared to net/pecl-oauth.

portlint: OK (looks fine.)
testport: 
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)
Comment 1 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-09-24 14:14:03 UTC
Danilo, it doesn't works here because of

=======================<phase: check-sanity   >============================
===>  pecl-oauth2-2.0.2 cannot be installed: doesn't work with lang/php56
port (doesn't support PHP 5.5 5.6).
*** Error code 1

It looks like you should somehow set the desired php version (70) in the port's Makefile. The same is for https://bugs.freebsd.org/212776
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-25 02:04:13 UTC
Hi Ruslan.

Actually, this port is specific for users running php 7.0, like devel/pecl-raphf and pecl-raphf2.

The same happens on bug 212776 (textproc/pecl-xdiff2) and bug 212767 (math/pecl-stats2).

Thank you for taking a look on these bugs.

If it is not too much to ask, could you also take a look on bug 212766 ?

Best regards.
Comment 3 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-09-26 10:05:26 UTC
Hi, 

yes, I understand that, but package build fails, so we can't commit it in such state. You need to somehow force the framework to use php70 for this port (maybe DEFAULT_PHP_VER=70 knob). 

Btw, do you use poudriere to testing ports? If not please read this:
https://www.freebsd.org/doc/en/books/porters-handbook/testing-poudriere.html

As for bug 212766 - I taked it.
Comment 4 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-27 20:40:36 UTC
Created attachment 175205 [details]
pecl-oauth2-v02.shar


Yes, I am using poudriere but I was testing these ports with DEFAULT_VERSIONS on the jail's make.conf

I've inserted "DEFAULT_VERSIONS+= php=70" on this and the others submitions, bug 212776 (textproc/pecl-xdiff2) and bug 212767 (math/pecl-stats2).

portlint: OK (looks fine.)

another around of `poudriere testport`: 
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)

Thank you Ruslan.
Comment 5 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-28 14:55:24 UTC
Hold down ports r422872
Comment 6 Mathieu Arnold freebsd_committer freebsd_triage 2016-09-28 15:25:26 UTC
(In reply to Ruslan Makhmatkhanov from comment #1)
> Danilo, it doesn't works here because of
> 
> =======================<phase: check-sanity   >============================
> ===>  pecl-oauth2-2.0.2 cannot be installed: doesn't work with lang/php56
> port (doesn't support PHP 5.5 5.6).
> *** Error code 1
> 
> It looks like you should somehow set the desired php version (70) in the
> port's Makefile. The same is for https://bugs.freebsd.org/212776

No.

A port should not set the default PHP version.  The only exceptions are php modules that are specific to a PHP version, like the redis ones.
Comment 7 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-09-28 15:32:38 UTC
So what should be done to make this built with poudriere?
Comment 8 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-09-28 15:32:59 UTC
(In reply to Mathieu Arnold from comment #6)

So what should be done to make this built with poudriere?
Comment 9 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-28 15:36:50 UTC
(In reply to Ruslan Makhmatkhanov from comment #7)

Insert "DEFAULT_VERSIONS= php=70" on the jail's make.conf
Comment 10 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-09-28 15:43:44 UTC
(In reply to Danilo G. Baio (dbaio) from comment #9)
It's ok for local builds, yes, but what about official packages? It can't be done at package build cluster, because it will affect all php packages.
Comment 11 Danilo G. Baio freebsd_committer freebsd_triage 2016-09-28 16:49:34 UTC
(In reply to Ruslan Makhmatkhanov from comment #10)

yes, it won't build... like happens on devel/pecl-raphf2 for instance:
http://portsmon.freebsd.org/portoverview.py?category=devel&portname=pecl-raphf2

it will only build when the default php version is 70.
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-10-10 20:13:09 UTC
A commit references this bug:

Author: rm
Date: Mon Oct 10 20:12:32 UTC 2016
New revision: 423698
URL: https://svnweb.freebsd.org/changeset/ports/423698

Log:
  pecl-oauth is a php interface to the oauth protocol.
  Oauth is an authorization protocol built on top of
  HTTP which allows applications to securely access
  data without having to store usernames and passwords.

  WWW: http://pecl.php.net/package/oauth/

  PR:		212773
  Submitted by:	dbaio@bsd.com.br

Changes:
  head/net/Makefile
  head/net/pecl-oauth2/
  head/net/pecl-oauth2/Makefile
  head/net/pecl-oauth2/distinfo
  head/net/pecl-oauth2/pkg-descr
Comment 13 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-10-10 20:14:11 UTC
New port added, thank you!