Created attachment 175399 [details] Patch to bring mail/mutt to 1.7.0 See attached patch and poudriere testport for {9,10}{amd64,i386}
Created attachment 175400 [details] 10amd64 testport
Created attachment 175401 [details] 10i386 testport
Created attachment 175402 [details] 9amd64 testport
Created attachment 175403 [details] 9i386 testport
Thanks. As pointed out in a separate email I will no longer be able to maintain this port, thus an additional change for the maintainer in Makefile would be good. Udo
Comment on attachment 175399 [details] Patch to bring mail/mutt to 1.7.0 Thanks. Udo, please flag the attachments for ports you're maintainer of with maintainer-approval+ so we can track them better.
Who's the new maintainer?
Derek, do you want to maintain this port? If you don't, I'll take it, but this is a great patch you've submitted and I think you should do it.
(In reply to Adam Weinberger from comment #8) Sure, that would be great. Should a new patch be submitted obsoleting the old with the MAINTAINER change?
No, I can manage :-) I'm also making a few small changes (using a few more OPTIONS helpers and a few spacing nits). In future patches, please make sure that you have tabs after =, never spaces.
A commit references this bug: Author: adamw Date: Wed Oct 5 22:55:30 UTC 2016 New revision: 423394 URL: https://svnweb.freebsd.org/changeset/ports/423394 Log: Update to 1.7.0. The sidebar patch is now an official part of mutt, and is now controlled by a SIDEBAR option. The trash patch is now a non-optional part of mutt so its knob has disappeared completely. Also, pass maintainership to submitter. Udo has looked after this port for a long time; many thanks to him for all his work! Changes for 1.7.0: ! Improved alignment when using multi-column characters with soft-fill (%*X) and right-justified (%>X) format strings. + The COLUMNS environment variable will be set to the width of the pager when invoking display filters. This can be used in copiousoutput mailcap entries to allow their output to match the pager width. + The sidebar patch has been merged. Please watch for airborne bovine. See the documentation for all the options, or simply enable it with 'set sidebar_visible'. + $mail_check_stats and $mail_check_stats_interval control whether, and how often, to scan for unread, flagged, and total message counts when checking for new mail in mailboxes. These statistics can be displayed in the sidebar and browser. + $trash, when set, specifies the path of the folder where mails marked for deletion will be moved, instead of being irremediably purged. + The <purge-message> function can be used to delete an entry and bypass the trash folder. + $folder_format has new format strings %m and %n, to display total and unread message counts for mailboxes. Note that $mail_check_stats should be enabled to use these. ! When browsing IMAP, %N will now display 'N', instead of the unread message count. Please use %n to display unread messages. PR: 213180 Submitted by: dereks lifeofadishwasher com Approved by: outgoing maintainer (Udo Schweigert) Changes: head/mail/mutt/Makefile head/mail/mutt/distinfo head/mail/mutt/files/extra-patch-greeting head/mail/mutt/files/extra-patch-ifdef head/mail/mutt/files/extra-patch-maildir-mtime head/mail/mutt/files/extra-patch-maildir-mtime-nntp head/mail/mutt/files/extra-patch-pgp-dw head/mail/mutt/files/extra-patch-sidebar head/mail/mutt/files/extra-patch-sidebar-nntp head/mail/mutt/files/extra-patch-sidebar-refresh head/mail/mutt/files/extra-patch-trash-purge head/mail/mutt/files/patch-date-conditional head/mail/mutt/files/patch-smime-self head/mail/mutt/files/patch-threadcomplete
Okay Derek, this is committed. This was a big patch and you did a great job with it. BUT, you need to do a couple things for your next patch. First of all, please install ports-mgmt/portlint and check things with 'portlint -C'. It's not always correct, but I caught some problems here with it. Second, the patches should be regenerated with 'make makepatch'. You don't need to submit a new PR for this, but please try to include it in the next mutt update. And third, and most importantly, somehow you were able to generate a distinfo file that didn't have a TIMESTAMP field. This has been in ports for a while now, so either you generated the file by hand (which you shouldn't do; c.f. TIMESTAMP), or you have a really old ports tree. If it's the latter, please make sure it is up-to-date!