Bug 213188 - Mk/Scripts/depends-list.sh: make clean is no longer recursive
Summary: Mk/Scripts/depends-list.sh: make clean is no longer recursive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Port Management Team
URL: https://reviews.freebsd.org/D7668
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-04 14:10 UTC by Tijl Coosemans
Modified: 2016-10-18 15:39 UTC (History)
5 users (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly?
koobs: exp-run+

Attachments
patch (1.15 KB, patch)
2016-10-04 14:10 UTC, Tijl Coosemans 		koobs: maintainer-approval? (portmgr)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2016-10-04 14:10:14 UTC 
Created attachment 175413 [details]
patch

Before ports r399712 limited-clean-depends (used by make clean) would recurse if WRKDIR existed.  After that it only cleans direct dependencies.  The attached patch restores the original behaviour.

Reported by: Gerhard Schmidt <schmidt@ze.tum.de>
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-09 11:35:05 UTC 
Known issue, wasn't tracked in Bugzilla. Assign to Fukang accordingly (original and fix patch author)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-09 11:37:44 UTC 
Behaviour of HEAD and quarterly should not differ
Comment 3 Fukang Chen freebsd_committer freebsd_triage 2016-10-10 05:23:46 UTC 
Thanks Tijl for the patch, it looks better.
Comment 4 Fukang Chen freebsd_committer freebsd_triage 2016-10-10 05:26:03 UTC 
Thanks Kubilay for adding me to the Cc: list. I've closed D7668, this patch looks better, 
and I don't have the permission to commit it, change assignee back to portmgr@.
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2016-10-11 16:44:09 UTC 
With the few tests I ran, it seems to work without breaking anything else.
Wondering if it needs an exp-run.
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2016-10-13 06:14:02 UTC 
Exp-run didn't show any regression.
Comment 7 Tijl Coosemans freebsd_committer freebsd_triage 2016-10-17 15:52:46 UTC 
Approved?
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-10-18 15:27:44 UTC 
A commit references this bug:

Author: mat
Date: Tue Oct 18 15:27:26 UTC 2016
New revision: 424170
URL: https://svnweb.freebsd.org/changeset/ports/424170

Log:
  Make make clean be recursive again.

  PR:		213188
  Submitted by:	tijl
  Exp-run by:	antoine
  Sponsored by:	Absolight

Changes:
  head/Mk/Scripts/depends-list.sh