Bug 213320 - net-im/pecl-stomp: Configure PORTSCOUT, Take MAINTAINER'ship
Summary: net-im/pecl-stomp: Configure PORTSCOUT, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-08 22:37 UTC by Danilo G. Baio
Modified: 2016-11-23 14:55 UTC (History)
2 users (show)

See Also:

Attachments
pecl-stomp-portscout.patch (803 bytes, patch)
2016-10-08 22:37 UTC, Danilo G. Baio 		no flags Details | Diff
pecl-stomp-portscout_v02.patch (950 bytes, patch)
2016-11-08 16:10 UTC, Danilo G. Baio 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo G. Baio freebsd_committer freebsd_triage 2016-10-08 22:37:22 UTC 
Created attachment 175542 [details]
pecl-stomp-portscout.patch

- Configure PORTSCOUT
- Add LICENSE_FILE
- Add DIST_SUBDIR (PECL)
- Update distinfo with TIMESTAMP
- Take maintainer'ship

portlint: OK (looks fine.)
testport: 
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)
Comment 1 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-11-08 11:43:56 UTC 
Hello Danilo,

i tested your patch, but sadly the distfile could not fetched with your changes:

===>  License PHP301 accepted by the user
===>   pecl-stomp-1.0.9_1 depends on file: /usr/local/sbin/pkg - found
=> PECL/stomp-1.0.9.tgz is not in /usr/ports/net-im/pecl-stomp/distinfo.
=> Either /usr/ports/net-im/pecl-stomp/distinfo is out of date, or
=> PECL/stomp-1.0.9.tgz is spelled incorrectly.
*** Error code 1

If i remove the line:
DIST_SUBDIR=   PECL

It is fetchable again. Can you please look at the issue?

It helps if you do a "make distclean" before the test. This will ensure, that the file is fetched and not used from local.

Greetings,
Torsten
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2016-11-08 16:10:36 UTC 
Created attachment 176793 [details]
pecl-stomp-portscout_v02.patch


After clean up my distfile I executed make makesum again and it worked... the checksum has changed because of this change on DIST_SUBDIR. I will pay more attention, thanks.

New patch attached.

portlint: OK (looks fine.)
testport:
	poudriere: i386,  9.3   (OK)
	poudriere: amd64, 9.3   (OK)
	poudriere: i386,  10.3  (OK)
	poudriere: amd64, 10.3  (OK)
	poudriere: i386,  11    (OK)
	poudriere: amd64, 11    (OK)
	poudriere: i386,  12    (OK)
	poudriere: amd64, 12    (OK)

Could you take a look on bug 213321 as well ? It's related with this.

Thank you.

Regards.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-11-17 11:33:04 UTC 
A commit references this bug:

Author: tz
Date: Thu Nov 17 11:32:46 UTC 2016
New revision: 426283
URL: https://svnweb.freebsd.org/changeset/ports/426283

Log:
  net-im/pecl-stomp: Pass maintainership to Danilo G. Baio (dbaio)

  Also:
  - Configure PORTSCOUT
  - Add LICENSE_FILE
  - Add DIST_SUBDIR (PECL)

  PR:           213320
  Submitted by: Danilo G. Baio <dbaio@bsd.com.br>
  Approved by:  mentors (implicit)

Changes:
  head/net-im/pecl-stomp/Makefile
  head/net-im/pecl-stomp/distinfo
Comment 4 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-11-17 11:41:40 UTC 
Committed, thanks for your patch and your patience!
And of course thanks for taking care of an port.
Comment 5 noahwater47 2016-11-23 14:55:17 UTC 
Thanks! Executed after the fix and run okay.
Back up patch stored at http://www.buythesisonline.org just in case.