Created attachment 175552 [details] patch This patch: * Updates to the currently latest revision * Unbreaks GUI by applying two patches: ** Patch in boost headers to prevent EINPROGRESS mishandling (https://github.com/zaphoyd/websocketpp/issues/563) ** Patch in websocketpp fixing IPv4 vs. IPv6 mismatch (https://github.com/zaphoyd/websocketpp/issues/587) * GUI option is made default * Clones icons for the GUI app cadabra2-gui * Adds "USE_TEX=texmf texhash" to allow for unincluded latex macros, and to make tex hash local packages installed by cadabra2 Verified that cadabra2 GUI now works fine - it is able to run many examples from their website.
Created attachment 175581 [details] patch Upstream accepted some patches, and fixed compiler warnings.
Created attachment 175582 [details] patch
Created attachment 175588 [details] patch
Created attachment 175595 [details] patch Unbundled devel/websocketpp.
somehow, some files are missing: ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: %%DATADIR%%/manual/algorithms/asym.cnb Error: Missing: %%DATADIR%%/manual/algorithms/canonicalise.cnb Error: Missing: %%DATADIR%%/manual/algorithms/collect_factors.cnb Error: Missing: %%DATADIR%%/manual/algorithms/collect_terms.cnb Error: Missing: %%DATADIR%%/manual/algorithms/combine.cnb Error: Missing: %%DATADIR%%/manual/algorithms/complete.cnb Error: Missing: %%DATADIR%%/manual/algorithms/decompose_product.cnb Error: Missing: %%DATADIR%%/manual/algorithms/drop_weight.cnb Error: Missing: %%DATADIR%%/manual/algorithms/eliminate_kronecker.cnb Error: Missing: %%DATADIR%%/manual/algorithms/eliminate_metric.cnb Error: Missing: %%DATADIR%%/manual/algorithms/epsilon_to_delta.cnb [...]
If the quarterly version is also affected (broken GUI), it would be great for this (and all bug reports in general) to separate version updates from other changes, so that they can be merged for quarterly users to benefit from improvements & fixes
Created attachment 175981 [details] shar archive Hi Kurt, I reverted and updated from subversion, reapplied the patch, and it still builds and passes stage-qa for me on 10.3 amd64. I am attaching the shar of the directory that builds. Yuri
GUI isn't technically required to run cadabra2, so we probably shouldn't worry about GUI fix only update on quarterly. Just don't merge into quarterly imo.
Do you build in poudriere or on a host loaded with other ports ?
build-failure, e.g. on 11a: http://people.freebsd.org/~pi/logs/math__cadabra2-11a-1476955893.txt
It builds fin on 10.3 in both poudriere and full of installed ports machine. There is some cmake or pkgconf issue on 11 causing it to not detect tex/boost. I am investigating.
I had it fail on 10.3i, too: http://people.freebsd.org/~pi/logs/math__cadabra2-10i-1476955893.txt
Here is one additional thing I don't understand: why in your builds GUI=off when the default is "on"? > ---Begin OPTIONS List--- > ===> The following configuration options are available for cadabra2-2.0.930: > GUI=off: GUI (Graphical User Interface) support > ===> Use 'make config' to modify these settings > ---End OPTIONS List--- On my system it comes up as "on" when not set by 'make config', and same in poudriere. Port says: > OPTIONS_DEFINE= GUI > OPTIONS_DEFAULT=GUI so it should be "on".
Testbuilds with GUI=on are OK. The build fails if GUI is OFF because the pkg-plist is wrong. Adding some %%GUI%% to the pkg-plist does not solve the root-cause, but it's worth a try.
Created attachment 176007 [details] patch-v2 With this, the pkg-plist is modified for the GUI-off case, and builds fine. Please approve.
It passed for me with both GUI=on and GUI=off. I will update once I find the reason.
Comment on attachment 176007 [details] patch-v2 Kurt, you are right, these should be prefixed with %%GUI%%, but stage-qa doesn't fail for me for some reason.
Approved.
Committed, thanks!
A commit references this bug: Author: pi Date: Fri Oct 21 09:01:11 UTC 2016 New revision: 424395 URL: https://svnweb.freebsd.org/changeset/ports/424395 Log: math/cadabra2: update 2.0.816 -> 2.0.930 - Unbreaks GUI by applying two patches: - Patch in boost headers to prevent EINPROGRESS mishandling https://github.com/zaphoyd/websocketpp/issues/563 - Patch in websocketpp fixing IPv4 vs. IPv6 mismatch https://github.com/zaphoyd/websocketpp/issues/587 - GUI option is made default - Clones icons for the GUI app cadabra2-gui - Adds "USE_TEX=texmf texhash" to allow for unincluded latex macros, and to make tex hash local packages installed by cadabra2 - Verified that cadabra2 GUI now works fine - it is able to run many examples from their website. PR: 213329 Submitted by: Yuri Victorovich <yuri@rawbw.com> (maintainer) Changes: head/math/cadabra2/Makefile head/math/cadabra2/distinfo head/math/cadabra2/files/patch-CMakeLists.txt head/math/cadabra2/files/patch-override_include_boost_asio_detail_impl_socket__ops.ipp head/math/cadabra2/files/patch-override_include_websocketpp_transport_asio_endpoint.hpp head/math/cadabra2/pkg-plist