Created attachment 175766 [details] Fix ss_vncviewer to avoid passing obsolete flag to netstat ss_vncviewer calls "netstat -ant" which now produces a usage error. This error may interfere with the port-inuse computation. Attached patch does two things: 1. Undo previous substitution s/Linux/FreeBSD/ in OS detection; bsd case is now handled correctly in a later clause 2. Remove 't' option in call to netstat
Comment on attachment 175766 [details] Fix ss_vncviewer to avoid passing obsolete flag to netstat The port is unmaintained, implicit approval.
Thanks for your submission. Since this effectively changes the package, PORTREVISION should be bumped. Also please confirm the changes pass QA (portlint, poudriere).
Created attachment 175838 [details] Fix ss_vncviewer to avoid passing obsolete flag to netstat
Patch updated to bump PORTREVISION. Builds with poudriere. Running "poudriere testport" with USE_PORTLINT=yes in poudriere.conf yields some warnings and one fatal error unrelated to this change: [00:00:08] ====>> Portlint check WARN: Makefile: you should only use ".if ${PORT_OPTIONS:MDOCS}" to wrap installation of files into /usr/local/share/doc if the collection of files is large and it takes considerable time to copy. WARN: Makefile: the port uses Java but is not part of the ``java'' category WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them. WARN: /v2/poudriere/data/.m/100s-280974-amd64-th-160618-hairball/ref/usr/ports/net/ssvnc/files/patch-Makefile: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. FATAL: Makefile.orig: for safety, be sure to cleanup backup files before committing the port. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 1 fatal error and 6 warnings found.
Comment on attachment 175838 [details] Fix ss_vncviewer to avoid passing obsolete flag to netstat Implicit approval, the port has no maintainer.
A commit references this bug: Author: jhale Date: Fri Dec 9 15:41:01 UTC 2016 New revision: 428224 URL: https://svnweb.freebsd.org/changeset/ports/428224 Log: Remove nonexistent -t option from call to netstat(1) [1] Convert to options helpers Install everything with BSD_INSTALL_* instead of cp to set correct permissions and strip binaries Pet portlint and stage-qa PR: 213490 [1] Submitted by: G. Paul Ziemba <p-fbsd-bugs@ziemba.us> [1] Changes: head/net/ssvnc/Makefile head/net/ssvnc/files/patch-Makefile head/net/ssvnc/files/patch-vncstorepw_Makefile head/net/ssvnc/files/patch-wr__tool
Committed, thanks!