Bug 213512 - x11-fonts/webfonts: Sync fonts collection with mscorefonts2
Summary: x11-fonts/webfonts: Sync fonts collection with mscorefonts2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jimmy Olgeni
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-15 20:18 UTC by Vladimir Kondratyev
Modified: 2016-10-19 09:58 UTC (History)
2 users (show)

See Also:
olgeni: maintainer-feedback+

Attachments
x11-fonts.webfonts.patch (5.44 KB, patch)
2016-10-15 20:18 UTC, Vladimir Kondratyev 		olgeni: maintainer-approval+
Details | Diff
poudriere build log (14.76 KB, text/x-log)
2016-10-15 20:57 UTC, Vladimir Kondratyev 		no flags Details
verdana-version-knob.patch (3.19 KB, patch)
2016-10-19 07:48 UTC, Vladimir Kondratyev 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Kondratyev freebsd_committer freebsd_triage 2016-10-15 20:18:42 UTC 
Created attachment 175789 [details]
x11-fonts.webfonts.patch

Sync fonts collection with mscorefonts2[1]. This includes:

1. Update Arial, Times, Trebuchet and Verdana fonts to y2006 version
2. Include cleartype fonts: Calibri, Cambria, Consolas, Constantia and Corbel

[1] http://mscorefonts2.sourceforge.net/
Comment 1 VK freebsd_triage 2016-10-15 20:37:18 UTC 
Comment on attachment 175789 [details]
x11-fonts.webfonts.patch

Thank you for your contribution. Please remember to set the maintainer-approval(?) request flag on attachments for ports you're not maintainer of (under attachment Details), with the maintainer's e-mail address.
Comment 2 VK freebsd_triage 2016-10-15 20:47:22 UTC 
Also please confirm the changes pass QA (portlint, poudriere).
Comment 3 Vladimir Kondratyev freebsd_committer freebsd_triage 2016-10-15 20:57:33 UTC 
Created attachment 175793 [details]
poudriere build log
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-10-17 14:53:46 UTC 
A commit references this bug:

Author: olgeni
Date: Mon Oct 17 14:53:21 UTC 2016
New revision: 424121
URL: https://svnweb.freebsd.org/changeset/ports/424121

Log:
  Sync webfonts collection with mscorefonts2.

  - Update Arial, Times, Trebuchet and Verdana fonts to y2006 version.
  - Include ClearType fonts: Calibri, Cambria, Consolas, Constantia, Corbel.

  Add LICENSE information while I'm here.

  PR:		213512
  Submitted by:	Vladimir Kondratyev

Changes:
  head/x11-fonts/webfonts/Makefile
  head/x11-fonts/webfonts/distinfo
  head/x11-fonts/webfonts/pkg-descr
  head/x11-fonts/webfonts/pkg-plist
Comment 5 Jimmy Olgeni freebsd_committer freebsd_triage 2016-10-17 14:55:39 UTC 
Patch committed with a few minor changes (license+pkg-descr).

Thank you!
Comment 6 Joseph Mingrone freebsd_committer freebsd_triage 2016-10-18 02:47:31 UTC 
Some fonts appear strange in Firefox after this upgrade.

Before: http://ftfl.ca/misc/before_webfonts_upgrade.png
After: http://ftfl.ca/misc/after_webfonts_upgrade.png

Note the strange 'N' in, e.g., "News and Announcements".

~/.fonts.conf:
http://ftfl.ca/paste/.fonts.conf.html
Comment 7 Vladimir Kondratyev freebsd_committer freebsd_triage 2016-10-18 08:06:14 UTC 
(In reply to Joseph Mingrone from comment #6)
This is known problem with Verdana Bold

Try fontconfig hints from following link:

https://bugs.launchpad.net/ubuntu/+source/freetype/+bug/109734
Comment 8 Joseph Mingrone freebsd_committer freebsd_triage 2016-10-18 11:45:35 UTC 
Thanks for pointing that out.

I think the occasional weird letter is a lesser evil than disabling antialiasing for Verdana.

The fonts rendered correctly before.  Do you know what changed in this update to trigger the regression?
Comment 9 Joseph Mingrone freebsd_committer freebsd_triage 2016-10-19 02:25:44 UTC 
A reasonable workaround for anyone else having this problem is to replace verdana with a similar sans-serif font by adding something like this to ~/fonts.conf.

  <!-- replace verdana due to bug: -->
  <!-- https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213512 -->
  <match target="pattern">
    <test name="family"    qual="any"><string>verdana</string></test>
    <edit name="family" mode="assign"><string>dejavu sans</string></edit>
  </match>
Comment 10 Joseph Mingrone freebsd_committer freebsd_triage 2016-10-19 02:31:07 UTC 
Sorry, that should have been ~/.fonts.conf instead of ~/fonts.cont.
Comment 11 Vladimir Kondratyev freebsd_committer freebsd_triage 2016-10-19 07:48:42 UTC 
Created attachment 175930 [details]
verdana-version-knob.patch

I added Makefile knob to chose version (2.35 or 5.01) of Verdana font to install
Old version is default
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-10-19 09:05:07 UTC 
A commit references this bug:

Author: olgeni
Date: Wed Oct 19 09:04:41 UTC 2016
New revision: 424233
URL: https://svnweb.freebsd.org/changeset/ports/424233

Log:
  Provide a NEWVERDANA option (off by default) to install the y2006
  version of Verdana.

  Some glyphs of Verdana Bold y2006 are not rendered correctly by
  freetype in anti-aliased mode.

  PR:		213512
  Submitted by:	Vladimir Kondratyev

Changes:
  head/x11-fonts/webfonts/Makefile
  head/x11-fonts/webfonts/distinfo
  head/x11-fonts/webfonts/files/pkg-message.in
Comment 13 Jimmy Olgeni freebsd_committer freebsd_triage 2016-10-19 09:05:49 UTC 
(In reply to Vladimir Kondratyev from comment #11)

Nice work! Thanks!
Comment 14 Joseph Mingrone freebsd_committer freebsd_triage 2016-10-19 09:58:14 UTC 
(In reply to commit-hook from comment #12)
(In reply to Jimmy Olgeni from comment #13)

Even better.  Thank you.