Bug 213565 - [patch] devel/arm-none-eabi-newlib: Fix indentation, be more friendly w.r.t aggressively assigning variables
Summary: [patch] devel/arm-none-eabi-newlib: Fix indentation, be more friendly w.r.t a...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-17 13:34 UTC by Kyle Evans
Modified: 2016-10-17 21:14 UTC (History)
1 user (show)

See Also:

Attachments
svn(1) diff of devel/arm-none-eabi-newlib (1.64 KB, patch)
2016-10-17 13:34 UTC, Kyle Evans 		kevans: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2016-10-17 13:34:09 UTC 
Created attachment 175862 [details]
svn(1) diff of devel/arm-none-eabi-newlib

As it says on the tin:

* Fix excessive indentation (pointed out by danfe@)
* Be more friendly w.r.t aggressively assigning variables: Conditionally assign NEWLIB_TARGET, and CONFIGURE_ARGS+= in case we create a slave port from this needing a different NEWLIB_TARGET.
Comment 1 Boris Samorodov freebsd_committer freebsd_triage 2016-10-17 13:40:48 UTC 
Take.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-10-17 21:10:20 UTC 
A commit references this bug:

Author: bsam
Date: Mon Oct 17 21:09:34 UTC 2016
New revision: 424145
URL: https://svnweb.freebsd.org/changeset/ports/424145

Log:
  devel/arm-none-eabi-newlib: * Fix excessive indentation  [1]
  * Be more friendly w.r.t aggressively assigning variables: Conditionally
  assign NEWLIB_TARGET,  and CONFIGURE_ARGS+= in case we create a slave
  port from this needing a different NEWLIB_TARGET.

  PR:		213565
  Submitted by:	 Kyle Evans <bsdports@kyle-evans.net> (maintainer)
  Reported by:	danfe  [1]

Changes:
  head/devel/arm-none-eabi-newlib/Makefile
Comment 3 Boris Samorodov freebsd_committer freebsd_triage 2016-10-17 21:14:43 UTC 
Committed, thanks!