Bug 213692 - emulators/snes9x-gtk: Unbreak port by moving to Github
Summary: emulators/snes9x-gtk: Unbreak port by moving to Github
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason E. Hale
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-21 23:07 UTC by timon
Modified: 2017-01-07 13:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (root)


Attachments
Patch for Makefile, distinfo & files directory (5.85 KB, patch)
2016-10-21 23:07 UTC, timon
vlad-fbsd: maintainer-approval+
Details | Diff
snes9x-gtk-1.54.1 (6.69 KB, patch)
2016-11-13 13:41 UTC, Jason E. Hale
jhale: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description timon 2016-10-21 23:07:47 UTC
Created attachment 176046 [details]
Patch for Makefile, distinfo & files directory

Hi,

This is a patch to unbreak emulators/snes9x-gtk. Changes:
* Project moved to github
* All patches regenerated with make makepatch
* Set WRKSRC_SUBDIR instead of altering WRKSRC
* Use autoreconf for configure and Makefiles generation
Comment 1 VK freebsd_triage 2016-11-12 20:43:48 UTC
Comment on attachment 176046 [details]
Patch for Makefile, distinfo & files directory

Maintainer TIMEOUT, implicit approval.
Comment 2 VK freebsd_triage 2016-11-12 20:46:01 UTC
timon, thanks for the patch. Please confirm the changes pass QA (portlint, poudriere).
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2016-11-13 13:41:12 UTC
Created attachment 176953 [details]
snes9x-gtk-1.54.1

Might as well just update to 1.54.1 which is the latest release. This also allows for the removal of one patch that was fixed upstream (files/patch-gtk-src-gtk__s9x.cpp).

There were a few problems with the port that I fixed.  It builds fine with SDL12 and SDL2, but it had USE_SDL=sdl2, so I went with that and fixed the configure script to use 2.x.  I suppose this never really linked to SDL at all unless SDL12 was previously installed.

The PORTAUDIO option was broken as well. There is no audio/portaudio2.

Added a few missing dependencies reported by stage-qa, desktop-file-utils was listed twice, cleaned up OPTIONS, and updated WWW.

I did a quick run test and it seems to work fine with the keyboard, but I don't have a gamepad to test that functionality, so a tester would be appreciated.
Comment 4 Allison Reid 2016-11-23 22:00:18 UTC
Patch looks good to me but let me try it first to double check before approval. Will build tonight.
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2017-01-07 13:31:44 UTC
Comment on attachment 176953 [details]
snes9x-gtk-1.54.1

Have not heard back from the maintainer in over 6 weeks. Implicit approval.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-01-07 13:40:06 UTC
A commit references this bug:

Author: jhale
Date: Sat Jan  7 13:39:15 UTC 2017
New revision: 430784
URL: https://svnweb.freebsd.org/changeset/ports/430784

Log:
  Update to 1.54.1
  Unbreak fetch (project moved to Github)
  Clean up and fix some broken dependencies
  Regenerate patches with 'make makepatch'
  Use standard options descriptions when possible

  PR:		213692 (based on)
  Submitted by:	<timon@timon.net.nz>
  Approved by:	maintainer timeout
  MFH:		2017Q1 (blanket)

Changes:
  head/emulators/snes9x-gtk/Makefile
  head/emulators/snes9x-gtk/distinfo
  head/emulators/snes9x-gtk/files/patch-gtk-configure
  head/emulators/snes9x-gtk/files/patch-gtk-src-gtk__s9x.cpp
  head/emulators/snes9x-gtk/files/patch-screenshot.cpp
  head/emulators/snes9x-gtk/pkg-descr
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-01-07 13:46:13 UTC
A commit references this bug:

Author: jhale
Date: Sat Jan  7 13:45:08 UTC 2017
New revision: 430785
URL: https://svnweb.freebsd.org/changeset/ports/430785

Log:
  MFH: r430784

  Update to 1.54.1
  Unbreak fetch (project moved to Github)
  Clean up and fix some broken dependencies
  Regenerate patches with 'make makepatch'
  Use standard options descriptions when possible

  PR:		213692 (based on)
  Submitted by:	<timon@timon.net.nz>
  Approved by:	maintainer timeout

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/emulators/snes9x-gtk/Makefile
  branches/2017Q1/emulators/snes9x-gtk/distinfo
  branches/2017Q1/emulators/snes9x-gtk/files/patch-gtk-configure
  branches/2017Q1/emulators/snes9x-gtk/files/patch-gtk-src-gtk__s9x.cpp
  branches/2017Q1/emulators/snes9x-gtk/files/patch-screenshot.cpp
  branches/2017Q1/emulators/snes9x-gtk/pkg-descr