Created attachment 176234 [details] Patch - Fix byteorder detection, fixes build on arm - Enable tests - Add LICENSE_FILE - Optionize DOCS
Per what I read in <machine/endian.h>, underscoreless macros are deprecated variants. Also, I don't like patches too much. ;-) Would this sed(1)-based change below also fix the build on ARM for you (I've manually tested it on PowerPC by removing related checks): > post-patch: > @${REINPLACE_CMD} -e 's,/etc/,${PREFIX}&,' ${WRKSRC}/parse_cmdline.c >+ @${REINPLACE_CMD} -e '/BYTE_ORDER/s,__,_,g' \ >+ ${WRKSRC}/librhash/byte_order.h Other suggestions look fine (except that I don't like LICENSE_FILE for well-known licenses and stripping the binaries, but will leave them in respect for your work and consistency with other ports). Thank you.
(In reply to Alexey Dokuchaev from comment #1) > Per what I read in <machine/endian.h>, underscoreless macros are deprecated > variants. Also, I don't like patches too much. ;-) Would this sed(1)-based > change below also fix the build on ARM for you (I've manually tested it on > PowerPC by removing related checks): Yes, works fine, thank you!
A commit references this bug: Author: danfe Date: Fri Oct 28 14:32:54 UTC 2016 New revision: 424854 URL: https://svnweb.freebsd.org/changeset/ports/424854 Log: - Fix byte order detection to allow the build on ARM (armv6) - Enable tests, add LICENSE_FILE, optionize DOCS while here PR: 213847 Submitted by: amdmi3 Changes: head/security/rhash/Makefile
Port updated as of ports r424854. koobs@, if you want to merge it to quarterly branch be my guest, otherwise please close this PR.
I guess I'm closing it since no one showed any interest for a fortnight; also note that port was updated to version 1.3.4 as of ports r426100.