Bug 213985 - science/avogadro: fix for lang/gcc5
Summary: science/avogadro: fix for lang/gcc5
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-01 20:03 UTC by Kenneth Salerno
Modified: 2018-08-31 08:51 UTC (History)
3 users (show)

See Also:

Attachments
Fix for lang/gcc5 (624 bytes, patch)
2016-11-01 20:03 UTC, Kenneth Salerno 		no flags Details | Diff
Fix for lang/gcc5 (601 bytes, patch)
2016-11-02 11:34 UTC, Kenneth Salerno 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Salerno 2016-11-01 20:03:05 UTC 
Created attachment 176384 [details]
Fix for lang/gcc5
Comment 1 Gerald Pfeifer freebsd_committer freebsd_triage 2016-11-01 20:16:26 UTC 
Thanks for looking into this, Kenneth!

I am not familiar with this port, nor even Eigen, so I hope some other
committer will grab this, but one comment/suggestion on this patch:

++// fix for lang/gcc5
++#if __GNUC__ == 5 && __GNUC_MINOR__ == 4
++#undef minor
++#endif

Why check for __GNUC_MINOR__, especially with ==?  What if the lang/gcc5
port is updated to version 5.5?

Wouldn't it be best to just check for __GNUC__, ignoring __GNUC_MINOR__,
and perhaps even __GNUC__ >= 5?
Comment 2 Kenneth Salerno 2016-11-01 21:50:38 UTC 
Ha! Neither was I, but it's a prereq for building Kalzium, which is a neat little program part of kdeedu.

I don't disagree with your suggest to test for __GNUC__ >= 5, problem is though I have only tested with lang/gcc5 and do not know if lang/gcc6 has the same issue or not.

Thanks for your support, Gerald!
Comment 3 Kenneth Salerno 2016-11-02 10:48:49 UTC 
(In reply to Gerald Pfeifer from comment #1)
Hi, Gerald. I have tested lang/gcc6 and determined it does NOT have the same issue as lang/gcc5, so my test for __GNUC__ == 5 still stands as valid. I can consider removing __GNUC_MINOR__ == 4 however.
Comment 4 Kenneth Salerno 2016-11-02 11:34:24 UTC 
Created attachment 176419 [details]
Fix for lang/gcc5

Removed test for __GNUC_MINOR__
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-05-06 15:18:27 UTC 
A commit references this bug:

Author: miwi
Date: Sat May  6 15:17:38 UTC 2017
New revision: 440273
URL: https://svnweb.freebsd.org/changeset/ports/440273

Log:
  - Fix build with gcc5

  PR:		213985

Changes:
  head/science/avogadro/files/patch-libavogadro_src_extensions_crystallography_crystallographyextension.cpp
Comment 6 Gerald Pfeifer freebsd_committer freebsd_triage 2017-05-06 15:36:07 UTC 
Isn't this going to break again when lang/gcc5 goes from version 5.4 to 5.5?

It appears you applied the original patch instead of the one after my
feedback?  Cf. comment #1 and comment #4.
Comment 7 Mathieu Arnold freebsd_committer freebsd_triage 2017-07-06 13:52:42 UTC 
Assignee timeout. Give back to the pool.
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-21 16:40:57 UTC 
GCC 7 is the default now, GCC 5 is deprecated.

Can this be closed or do we need to amend the previous commit?