Bug 214458 - graphics/llpp: Fix 'crashes Firefox sometimes'
Summary: graphics/llpp: Fix 'crashes Firefox sometimes'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-13 00:04 UTC by Tobias Kortkamp
Modified: 2016-11-13 14:01 UTC (History)
1 user (show)

See Also:

Attachments
llpp.diff (1.08 KB, patch)
2016-11-13 00:04 UTC, Tobias Kortkamp 		tobik: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-11-13 00:04:25 UTC 
Created attachment 176940 [details]
llpp.diff

Filing in the category of 'spooky action at a distance'.  This
one is related to bug #199872 where Firefox would randomly crash
when exiting llpp (sometimes yes and sometimes no, you don't know which
beforehand).

I'm tired of rolling the dice every time I close a PDF file.  I found a
workaround to fix this that I explain like this: Firefox (or GTK+ apps in
general) seems to monitor ~/.config (not sure if true).  llpp writes to
~/.config/llpp.conf when it exits, which will trigger bug #199872.

This patch moves llpp's config file to ~/.llpp.conf instead, solving
this annoyance.

Poudriere testport FreeBSD 10.3/amd64 ok, portlint ok
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-13 14:01:03 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-11-13 14:01:34 UTC 
A commit references this bug:

Author: pi
Date: Sun Nov 13 14:00:51 UTC 2016
New revision: 426051
URL: https://svnweb.freebsd.org/changeset/ports/426051

Log:
  graphics/llpp: Fix 'crashes Firefox sometimes'

  - This one is related to bug #199872 where Firefox would randomly crash
    when exiting llpp (sometimes yes and sometimes no, you don't know which
    beforehand).
    Firefox (or GTK+ apps in general) seems to monitor ~/.config
    (not sure if true).  llpp writes to ~/.config/llpp.conf when it
    exits, which will trigger bug #199872.
  - This patch moves llpp's config file to ~/.llpp.conf instead, solving
    this annoyance.

  PR:		214458
  Submitted by:	Tobias Kortkamp <t@tobik.me> (maintainer)

Changes:
  head/graphics/llpp/Makefile
  head/graphics/llpp/files/patch-config.ml