Bug 214555 - devel/libvirt: fails to build if wireshark is installed
Summary: devel/libvirt: fails to build if wireshark is installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-16 01:27 UTC by Koichiro Iwao
Modified: 2020-05-21 19:11 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (novel)

Attachments
libvirt build log (7.47 KB, text/plain)
2016-11-16 01:27 UTC, Koichiro Iwao 		no flags Details
pkg info wireshark (1.58 KB, text/plain)
2016-11-16 01:27 UTC, Koichiro Iwao 		no flags Details
proposed fix (312 bytes, patch)
2016-11-16 15:41 UTC, Roman Bogorodskiy 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Koichiro Iwao freebsd_committer freebsd_triage 2016-11-16 01:27:23 UTC 
Created attachment 177043 [details]
libvirt build log

devel/libvirt fails to build if net/wireshark is installed.
After installing wireshark, it builds successfully.

See also attached log.
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2016-11-16 01:27:51 UTC 
Created attachment 177044 [details]
pkg info wireshark
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2016-11-16 15:41:54 UTC 
Created attachment 177079 [details]
proposed fix

Hi, thanks for the bug report!

Could you please check if the attached patch fixes the problem?

PS I was thinking about adding an option for wireshark, but apparently net/wireshark doesn't install the header file, so it cannot be built for now.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2016-11-17 09:31:13 UTC 
The patch solves the problem.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-11-17 16:34:26 UTC 
A commit references this bug:

Author: novel
Date: Thu Nov 17 16:34:02 UTC 2016
New revision: 426289
URL: https://svnweb.freebsd.org/changeset/ports/426289

Log:
  devel/libvirt: fix build when wireshark installed

  When wireshark is installed, libvirt automatically detects that and
  tries to build wireshark dissector plugin, but fails because net/wireshark
  doesn't provide required headers.

  So disable wireshark support explicitly.

  PR:		214555
  Submitted by:	Koichiro IWAO

Changes:
  head/devel/libvirt/Makefile
Comment 5 Roman Bogorodskiy freebsd_committer freebsd_triage 2016-11-17 16:36:55 UTC 
(In reply to Koichiro IWAO from comment #3)

Thanks for checking, I've committed the fix.
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-05-19 13:44:47 UTC 
A commit references this bug:

Author: takawata
Date: Tue May 19 13:44:33 UTC 2020
New revision: 361251
URL: https://svnweb.freebsd.org/changeset/base/361251

Log:
  Add LE Whitelist commands to hccontrol

  PR: 214555
  Submitted by Marc Veldman

Changes:
  head/usr.sbin/bluetooth/hccontrol/hccontrol.8
  head/usr.sbin/bluetooth/hccontrol/le.c
Comment 7 Ed Maste freebsd_committer freebsd_triage 2020-05-21 19:11:48 UTC 
Add reference to proper PR 246505 for commit r361251 with wrong reference