Bug 214808 - [PATCH] mail/lbdb: update to 0.42
Summary: [PATCH] mail/lbdb: update to 0.42
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-11-24 13:28 UTC by Niklaas Baudet von Gersdorff
Modified: 2017-01-04 19:21 UTC (History)
2 users (show)

See Also:
rakuco: maintainer-feedback-

Attachments
Update to version 0.42 (1.68 KB, patch)
2016-11-24 13:28 UTC, Niklaas Baudet von Gersdorff 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niklaas Baudet von Gersdorff 2016-11-24 13:28:13 UTC 
Created attachment 177354 [details]
Update to version 0.42

First time submitting an update+patch, so please bear with me.

Portlint gives some errors, but these I also got with the older version. For the patched version they are:

WARN: Makefile: GETENT appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
WARN: /usr/home/niklaas/ports-devel/lbdb/files/patch-mutt_ldap_query: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
0 fatal errors and 2 warnings found.

I don't know what GETENT does and what is it for in this particular case. And I refrained from recreating a patch because the current one seems to work. Probably the maintainer knows more. I'm happy to assist if I can help.

As you can see in the diff, I added LICENSE and some ${STRIP_CMD}, next to updating PORTVERSION, removing PORTREVISION, updating distinfo, and removing libexec/lbdb/munge-keeporder from pkg-plist.
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-12-26 11:17:31 UTC 
Maintainer timeout.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-12-26 11:56:22 UTC 
(In reply to Niklaas Baudet von Gersdorff from comment #0)
> WARN: Makefile: GETENT appears in PORT_OPTIONS:M, but is not listed in
> OPTIONS_DEFINE.

It looks like this got broken years ago in ports r319851, it's never been an actual option.
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-12-26 12:28:20 UTC 
I've fixed the GETENT part in ports r429501.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-12-26 12:36:35 UTC 
A commit references this bug:

Author: rakuco
Date: Mon Dec 26 12:36:25 UTC 2016
New revision: 429505
URL: https://svnweb.freebsd.org/changeset/ports/429505

Log:
  Update to 0.42.

  Also set LICENSE and strip the installed binaries.

  PR:		214808
  Submitted by:	Niklaas Baudet von Gersdorff <stdin@niklaas.eu>
  Approved by:	maintainer timeout (alexey@renatasystems.org, 32 days)

Changes:
  head/mail/lbdb/Makefile
  head/mail/lbdb/distinfo
  head/mail/lbdb/pkg-plist
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-12-26 12:37:46 UTC 
Committed, thank you for your patch. Compared to the version you submitted, I've also set LICENCE_FILE and changed LICENSE to GPLv2+, as the headers in each of the scripts say "gplv2 or later".
Comment 6 Niklaas Baudet von Gersdorff 2017-01-04 19:21:14 UTC 
Thanks a lot for taking care of this and extra patching!