Created attachment 177409 [details] patch to update scid to 4.6.4 The attached patch updates scid to 4.6.4. It should also fix #197129. I didn't reuse the patch in the ticket because the Makefile has changed significantly since 4.6.2. I tried to keep the patch small. It's up to the maintainer/commiter whether the whole Makefile should be converted to the BSD_INSTALL_* macros instead. Tested using poudriere testport on 11-RELEASE/amd64.
Created attachment 177410 [details] poudriere testport log
I got an automated request for maintainer feedback, so here it is. This patch looks fine and works for me, but I think that in general the older patch should be committed first, especially when it is a security fix. I still wonder why #197129 is still not committed half a year after it was successfully tested. Applying #197129 and then updating to 4.6.4 (checking back with your patch) is certainly slightly easier than updating to 4.6.4 first and then starting the transition to the BSD_INSTALL* macros again. That said, committing your patch is better than committing neither of the two patches.
A commit references this bug: Author: riggs Date: Wed Jan 4 08:01:52 UTC 2017 New revision: 430544 URL: https://svnweb.freebsd.org/changeset/ports/430544 Log: Update to upstream version 4.6.4 Detailed log: - Update to upstream version 4.6.4 - Fix potential security issue (installation of globally-writable files) PR: 214842 Submitted by: shoesoft@gmx.net Approved by: bsd@volki.at (maintainer) MFH: 2017Q1 Changes: head/games/scid/Makefile head/games/scid/distinfo head/games/scid/files/patch-Makefile.conf head/games/scid/pkg-plist
A commit references this bug: Author: riggs Date: Fri Jan 6 10:11:47 UTC 2017 New revision: 430698 URL: https://svnweb.freebsd.org/changeset/ports/430698 Log: MFH: r430544 Update to upstream version 4.6.4 Detailed log: - Update to upstream version 4.6.4 - Fix potential security issue (installation of globally-writable files) PR: 214842 Submitted by: shoesoft@gmx.net Approved by: bsd@volki.at (maintainer) Approved by: ports-secteam (junovitch) Changes: _U branches/2017Q1/ branches/2017Q1/games/scid/Makefile branches/2017Q1/games/scid/distinfo branches/2017Q1/games/scid/files/patch-Makefile.conf branches/2017Q1/games/scid/pkg-plist