Bug 214842 - games/scid: update to 4.6.4
Summary: games/scid: update to 4.6.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-11-26 09:47 UTC by Stefan Ehmann
Modified: 2017-01-06 10:16 UTC (History)
2 users (show)

See Also:
bsd: maintainer-feedback+
riggs: merge-quarterly+


Attachments
patch to update scid to 4.6.4 (13.00 KB, patch)
2016-11-26 09:47 UTC, Stefan Ehmann
no flags Details | Diff
poudriere testport log (54.05 KB, text/x-log)
2016-11-26 09:49 UTC, Stefan Ehmann
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Ehmann 2016-11-26 09:47:47 UTC
Created attachment 177409 [details]
patch to update scid to 4.6.4

The attached patch updates scid to 4.6.4.

It should also fix #197129. I didn't reuse the patch in the ticket because the Makefile has changed significantly since 4.6.2.

I tried to keep the patch small. It's up to the maintainer/commiter whether the whole Makefile should be converted to the BSD_INSTALL_* macros instead.

Tested using poudriere testport on 11-RELEASE/amd64.
Comment 1 Stefan Ehmann 2016-11-26 09:49:24 UTC
Created attachment 177410 [details]
poudriere testport log
Comment 2 Friedrich Volkmann 2016-12-25 23:31:52 UTC
I got an automated request for maintainer feedback, so here it is. This patch looks fine and works for me, but I think that in general the older patch should be committed first, especially when it is a security fix. I still wonder why #197129 is still not committed half a year after it was successfully tested. Applying #197129 and then updating to 4.6.4 (checking back with your patch) is certainly slightly easier than updating to 4.6.4 first and then starting the transition to the BSD_INSTALL* macros again.

That said, committing your patch is better than committing neither of the two patches.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-01-04 08:02:48 UTC
A commit references this bug:

Author: riggs
Date: Wed Jan  4 08:01:52 UTC 2017
New revision: 430544
URL: https://svnweb.freebsd.org/changeset/ports/430544

Log:
  Update to upstream version 4.6.4

  Detailed log:
  - Update to upstream version 4.6.4
  - Fix potential security issue (installation of
    globally-writable files)

  PR:		214842
  Submitted by:	shoesoft@gmx.net
  Approved by:	bsd@volki.at (maintainer)
  MFH:		2017Q1

Changes:
  head/games/scid/Makefile
  head/games/scid/distinfo
  head/games/scid/files/patch-Makefile.conf
  head/games/scid/pkg-plist
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-01-06 10:12:30 UTC
A commit references this bug:

Author: riggs
Date: Fri Jan  6 10:11:47 UTC 2017
New revision: 430698
URL: https://svnweb.freebsd.org/changeset/ports/430698

Log:
  MFH: r430544

  Update to upstream version 4.6.4

  Detailed log:
  - Update to upstream version 4.6.4
  - Fix potential security issue (installation of
    globally-writable files)

  PR:		214842
  Submitted by:	shoesoft@gmx.net
  Approved by:	bsd@volki.at (maintainer)

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/games/scid/Makefile
  branches/2017Q1/games/scid/distinfo
  branches/2017Q1/games/scid/files/patch-Makefile.conf
  branches/2017Q1/games/scid/pkg-plist