Bug 214956 - net/freerdp: X11_USE=xorg=... can't be split with whitespace
Summary: net/freerdp: X11_USE=xorg=... can't be split with whitespace
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on: 212004
Blocks:
  Show dependency treegraph
 
Reported: 2016-11-30 16:06 UTC by John Hein
Modified: 2016-12-11 04:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (kevans)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2016-11-30 16:06:05 UTC
For the X11_USE=xorg=... specification, you can't split it up with whitespace.  r419907 split the line and that doesn't work.  Notice the output of 'make -v USE_XORG -V X11_USE' with the break and then edit the Makefile to have a continous comma-separated list on one line and run that make -V again.
Comment 1 John Hein 2016-11-30 16:11:12 UTC
Also xcursor is in the xorg= list twice.
Comment 2 Kyle Evans freebsd_committer freebsd_triage 2016-11-30 16:13:32 UTC
(In reply to John Hein from comment #1)

Hi John,

Ahh, sorry about that! =( There's an ongoing effort in PR 212004 to update this port to a newer version -- fixing this has been included in that effort, and we'll remove the xcursor duplication as well.
Comment 3 John Hein 2016-11-30 16:56:35 UTC
No problem.  I saw that bug and was going to test the update myself.  That's when I noticed this X11_USE issue.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-12-11 04:38:04 UTC
A commit references this bug:

Author: woodsb02
Date: Sun Dec 11 04:36:59 UTC 2016
New revision: 428330
URL: https://svnweb.freebsd.org/changeset/ports/428330

Log:
  net/freerdp: Update to 2.0.0 pre-release (GitHub as of 2016.11.24)

  - This update brings in the latest 2 years of FreeRDP project work,
    which has had a long time between tagging releases.
  - Remove DIRECTFB option, as it no longer compiles, and gets little
    upstream maintenance
  - Use NEON on aarch64, and optionally on armv6
  - Mark as broken on armv6 on FreeBSD 11.0-RELEASE and early versions
    of 12.0-CURRENT
  - Fix issue with X11_USE=xorg= being truncated due to whitespace as it
    wrapped over multiple lines
  - Move installed *.cmake files to correct location for modules

  net/freerdp1:
  - create new port based on previous net/freerdp 1.2.0, as it is required
    by net/guacamole-server

  net/vinagre:
  - patch to work with the new version of net/freerdp 2.0.0

  net/guacamole-server:
  - patch to work with net/freerdp1

  PR:		212004
  PR:		214956
  Submitted by:	Kyle Evans (maintainer)
  Reported by:	John Hein <z7dr6ut7gs@snkmail.com>
  Reviewed by:	Mikael Urankar <mikael.urankar@gmail.com>
  Reviewed by:	Ting-Wei Lan <lantw44@gmail.com>
  Reviewed by:	Antenore Gatta <antenore@simbiosi.org>
  Reviewed by:	amdmi3
  Approved by:	adamw (mentor)
  Differential Revision:	https://reviews.freebsd.org/D8712

Changes:
  head/net/Makefile
  head/net/freerdp/Makefile
  head/net/freerdp/distinfo
  head/net/freerdp/files/patch-CMakeLists.txt
  head/net/freerdp/files/patch-cmake-FindOpenSSL.cmake
  head/net/freerdp/files/patch-cmake_ConfigOptions.cmake
  head/net/freerdp/files/patch-cmake_FindGStreamer_1_0.cmake
  head/net/freerdp/files/patch-cmake_FindGStreamer__1__0.cmake
  head/net/freerdp/files/patch-ffmpeg29
  head/net/freerdp/files/patch-freerdp.pc.in
  head/net/freerdp/files/patch-git_1b663cef
  head/net/freerdp/files/patch-git_434436b7
  head/net/freerdp/files/patch-libfreerdp-locale-timezone.c
  head/net/freerdp/files/patch-libfreerdp_freerdp.pc.in
  head/net/freerdp/files/patch-winpr.pc.in
  head/net/freerdp/files/patch-winpr_winpr.pc.in
  head/net/freerdp/files/patch-z001-CMakeLists.txt
  head/net/freerdp/pkg-plist
  head/net/freerdp1/
  head/net/freerdp1/Makefile
  head/net/freerdp1/files/patch-client_X11_CMakeLists.txt
  head/net/freerdp1/files/patch-client_X11_ModuleOptions.cmake
  head/net/freerdp1/files/patch-client_X11_cli_CMakeLists.txt
  head/net/freerdp1/files/patch-client_X11_xfreerdp.1.xml.in
  head/net/freerdp1/files/patch-client_common_CMakeLists.txt
  head/net/freerdp1/files/patch-freerdp.pc.in
  head/net/freerdp1/files/patch-libfreerdp_CMakeLists.txt
  head/net/freerdp1/files/patch-winpr_tools_hash_CMakeLists.txt
  head/net/freerdp1/files/patch-winpr_tools_makecert_CMakeLists.txt
  head/net/freerdp1/pkg-plist
  head/net/guacamole-server/Makefile
  head/net/guacamole-server/files/patch-configure.ac
  head/net/vinagre/Makefile
  head/net/vinagre/files/patch-configure.ac
  head/net/vinagre/files/patch-plugins_rdp_vinagre-rdp-tab.c
Comment 5 Ben Woods freebsd_committer freebsd_triage 2016-12-11 04:40:56 UTC
Committed, thanks for reporting the issue John, and for working on the fix Kyle.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-12-11 04:47:13 UTC
A commit references this bug:

Author: woodsb02
Date: Sun Dec 11 04:46:38 UTC 2016
New revision: 428331
URL: https://svnweb.freebsd.org/changeset/ports/428331

Log:
  net/freerdp1: Fix issue with X11_USE=xorg= being truncated
  due to whitespace as it wrapped over multiple lines

  PR:		214956
  Submitted by:	Kyle Evans (maintainer)
  Reported by:	John Hein <z7dr6ut7gs@snkmail.com>
  Approved by:	adamw (mentor, implicit)

Changes:
  head/net/freerdp1/Makefile