Bug 214959 - games/iortcw: Update to 1.5a
Summary: games/iortcw: Update to 1.5a
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL: https://github.com/iortcw/iortcw/comp...
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-11-30 17:23 UTC by Tobias Kortkamp
Modified: 2016-12-23 22:40 UTC (History)
4 users (show)

See Also:


Attachments
iortcw.diff (3.10 KB, patch)
2016-11-30 17:23 UTC, Tobias Kortkamp
tobik: maintainer-approval+
Details | Diff
iortcw.diff (3.26 KB, patch)
2016-12-23 16:37 UTC, Tobias Kortkamp
tobik: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-11-30 17:23:52 UTC
Created attachment 177552 [details]
iortcw.diff

Update to iortcw 1.5a

- Disable use of OpenAL to fix segmentation faults on FreeBSD 11.0-RELEASE

Synth test on FreeBSD 11.0-RELEASE/amd64 ok, portlint ok: https://pkg.tobik.me/logs/games___iortcw.log
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-12-17 16:22:55 UTC
I'll take care
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-12-21 01:10:08 UTC
All build logs are fine on 10.3/i386, 10.3/amd64, 11.0/i386 and 11.0/amd64.
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2016-12-23 01:48:52 UTC
(In reply to Carlos J. Puga Medina from comment #2)
Carlos/Tobias,
It's a bit too late now, if the port used DISTVERSION originally than the 1.42d tag would have translated to a version of 1.42.d while still allowing fetch as 1.42d. Then we wouldn't need to bump PORTEPOCH on an update like this.

The result with DISTVERSION still needs a PORTEPOCH bump (pkg version -t 1.42d 1.5.a), but given all the tags in Github are formatted like this it seems prudent to switch to avoid weird situations in the future.

If you both agree, Carlos, approved with DISTVERSION instead of PORTVERSION.
Comment 4 Jason Unovitch freebsd_committer freebsd_triage 2016-12-23 01:54:55 UTC
Additionally, the change in pkg-message would be appropriate to replace with SUB_FILES/SUB_LIST to fill out the version accordingly. There are several examples in the tree.  A quick grep shows audio/xmms-nsf pops up first.  I would prefer to see the variable so it minimizes human error on updates and the pkg-message stays in sync.
Comment 5 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-12-23 16:25:54 UTC
(In reply to Jason Unovitch from comment #3)

Thanks Jason. If Tobias agrees, I'll proceed accordingly.
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2016-12-23 16:37:43 UTC
Created attachment 178231 [details]
iortcw.diff

Thanks. TIL about DISTVERSION. I'm attaching an updated diff for this. So yes, I agree :)
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-12-23 17:30:43 UTC
A commit references this bug:

Author: cpm
Date: Fri Dec 23 17:30:05 UTC 2016
New revision: 429276
URL: https://svnweb.freebsd.org/changeset/ports/429276

Log:
  games/iortcw: Update to 1.5a

  - Update iortcw to 1.5a
  - Use DISTVERSION instead of PORTVERSION
  - Bump PORTEPOCH
  - Disable use of OpenAL to fix segmentation faults on FreeBSD 11.0-RELEASE
  - Dynamically adjust pkg-message

  PR:		214959
  Submitted by:	Tobias Kortkamp <t@tobik.me> (maintainer)
  Reviewed by:	junovitch
  Approved by:	junovitch (mentor)

Changes:
  head/games/iortcw/Makefile
  head/games/iortcw/distinfo
  head/games/iortcw/files/Makefile
  head/games/iortcw/files/pkg-message.in
  head/games/iortcw/pkg-message
Comment 8 Carlos J. Puga Medina freebsd_committer freebsd_triage 2016-12-23 17:31:18 UTC
Committed, thanks!
Comment 9 Jason Unovitch freebsd_committer freebsd_triage 2016-12-23 22:40:21 UTC
(In reply to Tobias Kortkamp from comment #6)
Glad to help. Knowing that plus `pkg version -t <oldver> <newver>` helps a lot when it comes to sanity checking ports with weird version strings.