Bug 215501 - sysutils/spiped: allow setting optional flags per spiped instance in rc script
Summary: sysutils/spiped: allow setting optional flags per spiped instance in rc script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 22:19 UTC by Dave Cottlehuber
Modified: 2016-12-23 03:49 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (cperciva)

Attachments
v1 patch (1.83 KB, text/plain)
2016-12-22 22:19 UTC, Dave Cottlehuber 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Cottlehuber freebsd_committer freebsd_triage 2016-12-22 22:19:46 UTC 
Created attachment 178212 [details]
v1 patch

- spiped(1) has a bunch of useful flags that are not exposed via the rc.d
script today, let's fix that
- appease portlint & poudriere testport by using the `USES=ssl` format
while we are here

See discussion on http://mail.tarsnap.com/spiped/msg00160.html

# qa

- passes portlint -C
- poudriere bulk -t builds fine on 9, 10, 11 i386&amd64 but not tested on those platforms
- works on FreeBSD 11.0-p5 amd64 (using libressl)
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-12-23 03:48:23 UTC 
A commit references this bug:

Author: cperciva
Date: Fri Dec 23 03:47:39 UTC 2016
New revision: 429219
URL: https://svnweb.freebsd.org/changeset/ports/429219

Log:
  Add support for passing additional flags to spiped via new
  spiped_pipe_X_flags variables.  Replace USE_OPENSSL with
  USES ssl. [1]

  While I'm here, clarify the comment about needing C99 but
  preferring a compiler with AESNI support; it applies to the
  USES compiler:c11 part but not tar:tgz or ssl.

  PR:		215501
  Submitted by:	Dave Cottlehuber

Changes:
  head/sysutils/spiped/Makefile
  head/sysutils/spiped/files/spiped.in
Comment 2 Colin Percival freebsd_committer freebsd_triage 2016-12-23 03:49:59 UTC 
Thanks!  Committed (with a PORTREVISION bump and a minor comment clarification added).