Bug 215510 - www/gitlab: 8.11.11_3 replaces config file with default
Summary: www/gitlab: 8.11.11_3 replaces config file with default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-23 10:31 UTC by Martin Waschbüsch
Modified: 2017-01-12 16:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (tz)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Waschbüsch 2016-12-23 10:31:38 UTC
Updating gitlab from gitlab 8.11.11_1 to 8.11.11_3,

/usr/local/www/gitlab/lib/support/nginx/gitlab-ssl

got overwritten with the default contents.
This probably should not happen as it renders nginx inoperable until the file is adapted to the system once more.
Comment 1 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-12-23 10:36:35 UTC
Aloha Martin,

do i understand you correctly: you changed the content of:
/usr/local/www/gitlab/lib/support/nginx/gitlab-ssl

And after the update its back to the default content?

This would be indeed correct behavior :D

But i think i can work around this.
Comment 2 Martin Waschbüsch 2016-12-23 10:39:26 UTC
(In reply to Torsten Zuehlsdorff from comment #1)
Exactly.
I changed FQDN and cert / key filepath, but after the update it was all back to defaults.

Afaik, ports do not just overwrite config files if they've been edited?
Comment 3 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-12-23 12:13:51 UTC
(In reply to Martin Waschbüsch from comment #2)

> Afaik, ports do not just overwrite config files if they've been edited?

Yes, that is correct. But this files are not marked as config files.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-12-23 12:14:15 UTC
A commit references this bug:

Author: tz
Date: Fri Dec 23 12:13:33 UTC 2016
New revision: 429252
URL: https://svnweb.freebsd.org/changeset/ports/429252

Log:
  www/gitlab: Make shipped nginx config files @sample

  The shipped nginx config files require the user to change them. But
  after an update they are reset to the default-content. Now
  mark them as @sample so the will stay intact.

  PR:           215510
  Submitted by: Martin Waschb?sch <martin@waschbuesch.de>
  Approved by:  mentors (implicit)

Changes:
  head/www/gitlab/Makefile
  head/www/gitlab/pkg-plist
Comment 5 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-12-23 12:15:26 UTC
Fixed, thanks for the report! :)