Bug 215687 - graphics/darktable: Update to 2.2.0
Summary: graphics/darktable: Update to 2.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL: https://reviews.freebsd.org/D8994
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-31 16:34 UTC by Val Packett
Modified: 2017-01-06 00:34 UTC (History)
1 user (show)

See Also:
mandree: maintainer-feedback+


Attachments
Patch (10.72 KB, application/mbox)
2016-12-31 16:34 UTC, Val Packett
no flags Details
Patch (11.22 KB, patch)
2016-12-31 17:58 UTC, Val Packett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2016-12-31 16:34:43 UTC
Created attachment 178420 [details]
Patch

Update darktable to the new release 2.2.0.

(The patch in the patch puts the openjpeg 2 directory 'BEFORE' others because otherwise the preprocessor will include openjpeg 1.5's header if 1.5 is installed, and fail)
Comment 1 Val Packett 2016-12-31 17:58:02 UTC
Created attachment 178421 [details]
Patch
Comment 2 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2017-01-04 18:29:04 UTC
Hi!

Matthias Andree already prepared a patch which is available in Phabricator:
https://reviews.freebsd.org/D8994

I started to test this patch. Matthias is about to push a new fix to that patch (to restore the removal of "-ffast-math -fno-finite-math-only"). Once he did it, could you please try it too?

Thank you for your contribution!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-01-06 00:31:39 UTC
A commit references this bug:

Author: mandree
Date: Fri Jan  6 00:31:26 UTC 2017
New revision: 430672
URL: https://svnweb.freebsd.org/changeset/ports/430672

Log:
  Update to upstream release 2.2.1.

  ChangeLogs since previous 2.0.7:
  https://www.darktable.org/2016/12/darktable-2-2-0-released/
  https://www.darktable.org/2017/01/darktable-2-2-1-released/

  - Permit build on ARM64 (previously: AMD64 only)
  - Squish is no longer a build requisite, but po4a is for localized
    documentation.
  - USE_GEO -> USE_MAP in the cmake context
  - SLIDESHOW and GNOMEKEYRING options are gone upstream
  - Move to OpenJPEG 2.1 (used to use 1.5), needs a patch to the
    CMakeLists.txt to resolve include path shadows if both releases are
    installed.
  - Remove support for FreeBSD 9.3.

  Post-review-change: Take BUILD_DEPENDS on textproc/po4a and extend
  pkg-plist by several translated manual pages.

  PR:		215687 (related) [1]
  Submitted by:	Greg V [1], mandree@ (most)
  Reviewed by:	Roman Lebedev, dumbbell@
  Approved by:	dumbbell@
  Differential Revision:	https://reviews.freebsd.org/D8994

Changes:
  head/graphics/darktable/Makefile
  head/graphics/darktable/distinfo
  head/graphics/darktable/files/patch-data_CMakeLists.txt
  head/graphics/darktable/files/patch-doc_CMakeLists.txt
  head/graphics/darktable/files/patch-src_CMakeLists.txt
  head/graphics/darktable/pkg-plist
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2017-01-06 00:34:18 UTC
Thanks for the patch.

I've committed an update to v2.2.1 which has seen some review by one of the upstream authors and by the maintainer, from your port, the only thing that remained was the BUILD_DEPENDS on po4a, and I'd independently found that I need the BEFORE.

It appears that your provided patch would not have passed "make check-plist". Please use poudriere testport, or at least "make DEVELOPER=yes clean depends all stage stage-qa check-plist package" to make sure there are no issues with the pkg-plist.