Created attachment 178483 [details] Patch adds mysql80 ports to the tree This issue is opened for adding the mysql80-{server|client} ports to tree. A patch for that porpuse is attached. It's under review on the mentioned review link.
Please re-upload the Differential revision as a result of "svn cp". Basically, svn cp the mysql57-* ports and then do "arc diff --update D9031 databases". The arcanist tool should pick this up as a copy.
Normal "svn diff" output loses the copy component of this. There are instructions on how to use arcanist here: https://wiki.freebsd.org/action/show/Phabricator
Created attachment 178487 [details] Updated patch against mysql57 ports This is new-generated as requested it's generated upon mysql57 ports. Thanks for the hints ;)
Thank you!
Created attachment 178510 [details] New patch based on last commit of MySQL57
Thanks!
Created attachment 178549 [details] Updated patch reflecting the update of review (Fixing build for new c++11 static_checks) New update for patch fixes 'const' caused problems for mysql80 build.
A commit references this bug: Author: lifanov Date: Sat Jan 7 20:34:49 UTC 2017 New revision: 430827 URL: https://svnweb.freebsd.org/changeset/ports/430827 Log: add databases/mysql80-server and databases/mysql80-client This is a development snapshot of upcoming MySQL 8.0. PR: 215738 Submitted by: Mahdi Mokhtari <mokhi64@gmail.com> Reviewed by: matthew, feld Approved by: matthew (mentor), feld Differential Revision: https://reviews.freebsd.org/D9031 Changes: head/Mk/Uses/mysql.mk head/Mk/bsd.default-versions.mk head/databases/Makefile head/databases/mysql80-client/ head/databases/mysql80-client/Makefile head/databases/mysql80-client/files/patch-client_CMakeLists.txt head/databases/mysql80-client/files/patch-cmake_build__configurations_compiler__options.cmake head/databases/mysql80-client/pkg-message head/databases/mysql80-client/pkg-plist head/databases/mysql80-server/ head/databases/mysql80-server/Makefile head/databases/mysql80-server/distinfo head/databases/mysql80-server/files/patch-client_CMakeLists.txt head/databases/mysql80-server/files/patch-sql_histograms_histogram.h head/databases/mysql80-server/files/patch-sql_histograms_singleton.cc head/databases/mysql80-server/files/patch-sql_histograms_singleton.h head/databases/mysql80-server/files/patch-sql_json__dom.h head/databases/mysql80-server/files/patch-sql_sql__view.cc head/databases/mysql80-server/files/patch-storage_innobase_buf_buf0buf.cc head/databases/mysql80-server/files/patch-storage_innobase_dict_dict0stats.cc head/databases/mysql80-server/files/patch-storage_innobase_sync_sync0debug.cc head/databases/mysql80-server/files/patch-storage_innobase_trx_trx0purge.cc head/databases/mysql80-server/files/patch-storage_innobase_trx_trx0trx.cc head/databases/mysql80-server/pkg-descr head/databases/mysql80-server/pkg-message head/databases/mysql80-server/pkg-plist
Committed, thanks! FYI: a couple of patches still didn't apply cleanly. I looked at original code and just removed them. Please let me know if I messed up and I'll fix it.
(In reply to Nikolai Lifanov from comment #9) > Committed, thanks! Thanks :) > FYI: a couple of patches still didn't apply cleanly. > I looked at original code and just removed them. I updated my tree and compared the patches, all are exact and same. Which didn't apply cleanly?
Two patches were deleted as part of this update. The patch didn't carry deletions.
(In reply to Nikolai Lifanov from comment #11) Aha. Yeah. That's why I used `arc diff` instead of svn. As you and matthew suggested :)
(In reply to Mahdi Mokhtari from comment #12) All seems okay now. Thanks BTW ;)